From: devendra sharma <devendra.sharma9091@gmail.com>
To: abbotti@mev.co.uk
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
devendra sharma <devendra.sharma9091@gmail.com>
Subject: [PATCH] staging: comedi: dyna_pci10xx: fixed check patch warnings about memory barrier comments
Date: Mon, 19 Dec 2016 20:06:15 +0530 [thread overview]
Message-ID: <1482158175-3130-1-git-send-email-devendra.sharma9091@gmail.com> (raw)
Added comments before memory barrier
Signed-off-by: Devendra Sharma <devendra.sharma9091@gmail.com>
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index c9eb26f..c3b5236 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -122,6 +122,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
mutex_lock(&devpriv->mutex);
for (n = 0; n < insn->n; n++) {
+ /*multi-processor memory barrier*/
smp_mb();
/* trigger conversion and write data */
outw_p(data[n], dev->iobase);
@@ -141,6 +142,7 @@ static int dyna_pci10xx_di_insn_bits(struct comedi_device *dev,
u16 d = 0;
mutex_lock(&devpriv->mutex);
+ /*multi-processor memory barrier*/
smp_mb();
d = inw_p(devpriv->BADR3);
udelay(10);
@@ -161,6 +163,7 @@ static int dyna_pci10xx_do_insn_bits(struct comedi_device *dev,
mutex_lock(&devpriv->mutex);
if (comedi_dio_update_state(s, data)) {
+ /*multi-processor memory barrier*/
smp_mb();
outw_p(s->state, devpriv->BADR3);
udelay(10);
--
2.7.4
next reply other threads:[~2016-12-19 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 14:36 devendra sharma [this message]
2016-12-19 17:48 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482158175-3130-1-git-send-email-devendra.sharma9091@gmail.com \
--to=devendra.sharma9091@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®