From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 4/4] usb: xhci: warn on command timeout in stopped command ring
Date: Fri, 23 Dec 2016 14:52:58 +0800 [thread overview]
Message-ID: <1482475978-18203-5-git-send-email-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <1482475978-18203-1-git-send-email-baolu.lu@linux.intel.com>
If xhci host fails to response to a command, the command
watchdog timer will be fired. The callback function will
abort and clear current command and restart the command
execution. If driver fails to restart command execution,
it will assume there is a larger problem in host and
report the situation to the upper layer. In rare cases,
if the driver sees a command timeout in a stopped command
ring, driver should let the user know it.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/usb/host/xhci-ring.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 6a23c37..16baefc 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1308,8 +1308,12 @@ void xhci_handle_command_timeout(struct work_struct *work)
goto time_out_completed;
}
- /* command timeout on stopped ring, ring can't be aborted */
- xhci_dbg(xhci, "Command timeout on stopped ring\n");
+ /*
+ * We should never reach here until a command times out on a stopped
+ * ring and xhci driver has no idea about the reason why the command
+ * ring was stopped.
+ */
+ xhci_warn(xhci, "WARN command timeout on stopped ring\n");
xhci_handle_stopped_cmd_ring(xhci, xhci->current_cmd);
time_out_completed:
--
2.1.4
next prev parent reply other threads:[~2016-12-23 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 6:52 [PATCH 0/4] refactor command timeout handling Lu Baolu
2016-12-23 6:52 ` [PATCH 1/4] usb: xhci: remove unnecessary second abort try Lu Baolu
2016-12-23 6:52 ` [PATCH 2/4] usb: xhci: remove CRR polling in xhci_abort_cmd_ring() Lu Baolu
2016-12-23 6:52 ` [PATCH 3/4] usb: xhci: add XHCI_MISS_CA_EVENT quirk bit Lu Baolu
2016-12-23 6:52 ` Lu Baolu [this message]
2016-12-23 9:49 ` [PATCH 4/4] usb: xhci: warn on command timeout in stopped command ring Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482475978-18203-5-git-send-email-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome