From: David Howells <dhowells@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: dhowells@redhat.com, James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
keyrings@vger.kernel.org,
linux-security-module <linux-security-module@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] key: Convert big_key payload.data to struct
Date: Tue, 09 May 2017 09:11:24 +0100 [thread overview]
Message-ID: <14829.1494317484@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAGXu5jLYLeYWm9GKMm2_5iT4PjaXCi5qsGnZQ2JqFT0DVvmYog@mail.gmail.com>
Kees Cook <keescook@chromium.org> wrote:
> This doesn't protect you against changes in struct path size,
> though... the existing code (and this proposal) will break if that
> ever happens...
True - in which case you should kmalloc() it as Eric suggests.
> What's the problem with defining the types at the top level? That
> seems like a nice place to see them all at once.
It means adding a bunch of dependencies to linux/key.h and union key_payload.
Have you considered why we don't just put all the definitions for all the
filesystems in linux/fs.h? By this logic it would seem like a nice place to
see them all at once.
David
next prev parent reply other threads:[~2017-05-09 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 21:43 Kees Cook
2017-05-08 22:00 ` David Howells
2017-05-08 22:19 ` Eric Biggers
2017-05-08 22:26 ` Kees Cook
2017-05-09 7:24 ` David Howells
2017-05-09 21:45 ` Eric Biggers
2017-05-09 8:11 ` David Howells [this message]
2017-05-09 16:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14829.1494317484@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome