From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbcL3ESV (ORCPT ); Thu, 29 Dec 2016 23:18:21 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:39303 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbcL3EST (ORCPT ); Thu, 29 Dec 2016 23:18:19 -0500 X-AuditID: b6c32a2d-f79a76d0000074b4-2c-5865ddb13c1c From: Chanwoo Choi To: balbi@kernel.org, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chanwoo@kernel.org, Chanwoo Choi Subject: [PATCH v2 2/6] usb: phy: msm: Replace the extcon API Date: Fri, 30 Dec 2016 13:08:11 +0900 Message-id: <1483070895-8213-3-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1483070895-8213-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsWy7bCmlu7Gu6kRBrs6WCyOtT1ht5h44wqL xfUvz1ktmhevZ7O4vGsOm8XsJf0sFltfvmOyWLSsldmBw2PTqk42j/1z17B79G1ZxejxeZNc AEtUqk1GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0BlK CmWJOaVAoYDE4mIlfTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSM/VO/ shZ8kK2YuqGBuYHxjkQXIyeHhICJxMKVixkhbDGJC/fWs3UxcnEICSxllNjWc5UZwmlnknh3 6jJLFyMHWMeb6xEQ8TmMEj8XvWYF6RYS+MEocWuTDIjNJqAlsf/FDTaQehEBA4m2G2IgYWaB HYwS279Wg9jCArYSHU232EBsFgFVieNHprKA2LwCLhK/Hi9mgjhITuLDnkfsIDangKvEu23n WEH2Sgh8Z5N4dhLEAblHVmLTAWaIeheJbe+a2CFsYYlXx7dA2dISf5feYoToncwo0bX2LzOE 08Mo0bjmKBtElbHE/Qf3mCEu5ZPo/f2ECWIBr0RHmxCE6SExa7UahOko0b7IGBIMMxgl3rft Z5rAKLOAkWEVo1hqQXFuemqxaYGRXnFibnFpXrpecn7uJkZw0tHS3cH4ZYH3IUYBDkYlHt4F JakRQqyJZcWVuYcYJTiYlUR4C28DhXhTEiurUovy44tKc1KLDzGaAoNpIrOUaHI+MCHmlcQb mpgZmhhZAqG5obmSOO+CCusIIYH0xJLU7NTUgtQimD4mDk6pBsaIE3vO8mydt7o7IdDuUWRz jgLTDNH/Uw+m+m3KE+/I4j7iZPdLo/zezwe7GU3dNiekTz8+ZaPDgQkdq86vfHp4x2Zrofty EoH3PZNd6k/6vXmq9WXVlfbr8m+F+Xia7zxtYTT/83NSx0/3d8qb3AwYeDKjZhSm+ue5/6u7 Uv9w1Wv/SV1u/z4qsRRnJBpqMRcVJwIAmwyMD1ADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t9jQd0Nd1MjDE6tMLQ41vaE3WLijSss Fte/PGe1aF68ns3i8q45bBazl/SzWGx9+Y7JYtGyVmYHDo9NqzrZPPbPXcPu0bdlFaPH501y ASxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMvYP/Ura8EH2YqpGxqYGxjvSHQxcnBICJhIvLke0cXICWSKSVy4t56ti5GLQ0hg FqPExys3mCGcH4wS3be+sIFUsQloSex/cYMNpFlEwECi7YYYSA2zwA5GiXlLT4PVCAvYSnQ0 3QKzWQRUJY4fmcoCYvMKuEj8eryYCWKbnMSHPY/YQWxOAVeJd9vOsYLYQkA1y8+cYZ/AyLuA kWEVo0RqQXJBcVJ6rlFearlecWJucWleul5yfu4mRnBIP5PewXh4l/shRgEORiUe3h9lqRFC rIllxZW5hxglOJiVRHgLbwOFeFMSK6tSi/Lji0pzUosPMZoCHTaRWUo0OR8Yb3kl8YYm5ibm xgYW5paWJkZK4ryNs5+FCwmkJ5akZqemFqQWwfQxcXBKNTAGCiuekmt5Mn1R8mKbd5kPc3yv 7n3qeas40HmnnzND4faF5w4fen1O8qGhfJt/4KXs7Qk2Gu28rke0jYO+C5ssUr+w790rMYHt nrN7ve+G2F5utVZ/IvHUZg9L27pHGyw0OBYslE47uz3w/o3LbDzBuiczjKN6ebWybd97WWp+ 2fdjj/yyIy+VWIozEg21mIuKEwH4arEsfwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161230040816epcas5p4dc9f57b63a2e428a47f313d32146c5d7 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161230040816epcas5p4dc9f57b63a2e428a47f313d32146c5d7 X-RootMTR: 20161230040816epcas5p4dc9f57b63a2e428a47f313d32146c5d7 References: <1483070895-8213-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch uses the resource-managed extcon API for extcon_register_notifier() and replaces the deprecated extcon API as following: - extcon_get_cable_state_() -> extcon_get_state() Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi --- drivers/usb/phy/phy-msm-usb.c | 33 +++++++++++---------------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 8a34759727bb..a15a89d4235d 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -1742,14 +1742,14 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg) if (!IS_ERR(ext_vbus)) { motg->vbus.extcon = ext_vbus; motg->vbus.nb.notifier_call = msm_otg_vbus_notifier; - ret = extcon_register_notifier(ext_vbus, EXTCON_USB, - &motg->vbus.nb); + ret = devm_extcon_register_notifier(&pdev->dev, ext_vbus, + EXTCON_USB, &motg->vbus.nb); if (ret < 0) { dev_err(&pdev->dev, "register VBUS notifier failed\n"); return ret; } - ret = extcon_get_cable_state_(ext_vbus, EXTCON_USB); + ret = extcon_get_state(ext_vbus, EXTCON_USB); if (ret) set_bit(B_SESS_VLD, &motg->inputs); else @@ -1759,16 +1759,14 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg) if (!IS_ERR(ext_id)) { motg->id.extcon = ext_id; motg->id.nb.notifier_call = msm_otg_id_notifier; - ret = extcon_register_notifier(ext_id, EXTCON_USB_HOST, - &motg->id.nb); + ret = devm_extcon_register_notifier(&pdev->dev, ext_id, + EXTCON_USB_HOST, &motg->id.nb); if (ret < 0) { dev_err(&pdev->dev, "register ID notifier failed\n"); - extcon_unregister_notifier(motg->vbus.extcon, - EXTCON_USB, &motg->vbus.nb); return ret; } - ret = extcon_get_cable_state_(ext_id, EXTCON_USB_HOST); + ret = extcon_get_state(ext_id, EXTCON_USB_HOST); if (ret) clear_bit(ID, &motg->inputs); else @@ -1883,10 +1881,9 @@ static int msm_otg_probe(struct platform_device *pdev) */ if (motg->phy_number) { phy_select = devm_ioremap_nocache(&pdev->dev, USB2_PHY_SEL, 4); - if (!phy_select) { - ret = -ENOMEM; - goto unregister_extcon; - } + if (!phy_select) + return -ENOMEM; + /* Enable second PHY with the OTG port */ writel(0x1, phy_select); } @@ -1897,7 +1894,7 @@ static int msm_otg_probe(struct platform_device *pdev) if (motg->irq < 0) { dev_err(&pdev->dev, "platform_get_irq failed\n"); ret = motg->irq; - goto unregister_extcon; + return motg->irq; } regs[0].supply = "vddcx"; @@ -1906,7 +1903,7 @@ static int msm_otg_probe(struct platform_device *pdev) ret = devm_regulator_bulk_get(motg->phy.dev, ARRAY_SIZE(regs), regs); if (ret) - goto unregister_extcon; + return ret; motg->vddcx = regs[0].consumer; motg->v3p3 = regs[1].consumer; @@ -2003,11 +2000,6 @@ static int msm_otg_probe(struct platform_device *pdev) clk_disable_unprepare(motg->clk); if (!IS_ERR(motg->core_clk)) clk_disable_unprepare(motg->core_clk); -unregister_extcon: - extcon_unregister_notifier(motg->id.extcon, - EXTCON_USB_HOST, &motg->id.nb); - extcon_unregister_notifier(motg->vbus.extcon, - EXTCON_USB, &motg->vbus.nb); return ret; } @@ -2029,9 +2021,6 @@ static int msm_otg_remove(struct platform_device *pdev) */ gpiod_set_value_cansleep(motg->switch_gpio, 0); - extcon_unregister_notifier(motg->id.extcon, EXTCON_USB_HOST, &motg->id.nb); - extcon_unregister_notifier(motg->vbus.extcon, EXTCON_USB, &motg->vbus.nb); - msm_otg_debugfs_cleanup(); cancel_delayed_work_sync(&motg->chg_work); cancel_work_sync(&motg->sm_work); -- 1.9.1