mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
	Paul Burton <paul.burton@imgtec.com>
Subject: [PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table
Date: Mon,  2 Jan 2017 15:06:55 -0300	[thread overview]
Message-ID: <1483380416-9153-1-git-send-email-javier@osg.samsung.com> (raw)

The OF device ID table doesn't have a sentinel NULL entry and so it
causes the following error:

FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1493: recipe for target 'modules' failed
make: *** [modules] Error 2

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index bf43b5d2aafc..73bc826144d4 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
 	{ .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ },
 };
 
 /**
-- 
2.7.4

             reply	other threads:[~2017-01-02 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 18:06 Javier Martinez Canillas [this message]
2017-01-02 18:06 ` [PATCH 2/2] auxdisplay: img-ascii-lcd: Fix module autoload Javier Martinez Canillas
2017-02-20 13:52 ` [PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483380416-9153-1-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=paul.burton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®