From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934790AbdACIu4 (ORCPT ); Tue, 3 Jan 2017 03:50:56 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:18119 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757301AbdACIuU (ORCPT ); Tue, 3 Jan 2017 03:50:20 -0500 From: Yong Mao To: Ulf Hansson CC: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Matthias Brugger , Chunfeng Yun , Eddie Huang , Greg Kroah-Hartman , Philipp Zabel , Adrian Hunter , Shawn Lin , Baolin Wang , Russell King , Linus Walleij , Chaotian Jing , Douglas Anderson , Nicolas Boichat , Javier Martinez Canillas , yong mao , , , , , , Subject: [PATCH v2 2/2] mmc: mediatek: correct the implementation of msdc_card_busy Date: Tue, 3 Jan 2017 16:49:57 +0800 Message-ID: <1483433397-11756-3-git-send-email-yong.mao@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1483433397-11756-1-git-send-email-yong.mao@mediatek.com> References: <1483433397-11756-1-git-send-email-yong.mao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yong mao msdc_card_busy only need check if the data0 is low. In sdio data1 irq mode, data1 may be low because of interruption. Signed-off-by: Yong Mao Signed-off-by: Chaotian Jing --- drivers/mmc/host/mtk-sd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 10ef2ae..80ba034 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1074,11 +1074,8 @@ static int msdc_card_busy(struct mmc_host *mmc) struct msdc_host *host = mmc_priv(mmc); u32 status = readl(host->base + MSDC_PS); - /* check if any pin between dat[0:3] is low */ - if (((status >> 16) & 0xf) != 0xf) - return 1; - - return 0; + /* only check if data0 is low */ + return !(status & BIT(16)); } static void msdc_request_timeout(struct work_struct *work) -- 1.7.9.5