From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968802AbdADSd4 (ORCPT ); Wed, 4 Jan 2017 13:33:56 -0500 Received: from smtprelay0107.hostedemail.com ([216.40.44.107]:53260 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761671AbdADSdQ (ORCPT ); Wed, 4 Jan 2017 13:33:16 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:4321:5007:7875:10004:10400:10848:11026:11232:11473:11658:11914:12043:12294:12296:12438:12683:12740:12760:12895:13069:13161:13229:13311:13357:13439:14110:14181:14659:14721:21080:21451:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: hole34_6c241dd39ef5d X-Filterd-Recvd-Size: 1845 Message-ID: <1483554741.21292.9.camel@perches.com> Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style From: Joe Perches To: Ziyuan Xu , ulf.hansson@linaro.org, jh80.chung@samsung.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Jan 2017 10:32:21 -0800 In-Reply-To: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> References: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote: > Let's fix the warnings from checkpatch.pl: > > - line over 80 characters; > - block comments should align the * on each Lines; > - statements not starting on a tabstop. > > Signed-off-by: Ziyuan Xu > --- > > drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c [] > @@ -94,7 +94,8 @@ struct idmac_desc { > > __le32 des1; /* Buffer sizes */ > #define IDMAC_SET_BUFFER1_SIZE(d, s) \ > - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff))) > + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \ > + (cpu_to_le32((s) & 0x1fff))) Please look to improve code rather than just shut up the brainless checkpatch script. If this is really valuable, it'd probably be better as an inline function, or as it's only used once, just as direct code in that one place.