From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757669AbcEEPgH (ORCPT ); Thu, 5 May 2016 11:36:07 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:15699 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755727AbcEEPgE convert rfc822-to-8bit (ORCPT ); Thu, 5 May 2016 11:36:04 -0400 From: Amitkumar Karwar To: One Thousand Gnomes CC: "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ganapathi Bhat Subject: RE: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Topic: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Index: AQHRpuAk59qd14Lu9EyCOkg0CzMo9J+q64IA//+NfPA= Date: Thu, 5 May 2016 15:34:53 +0000 Message-ID: <14835803c03d47bebec4537e985180fc@SC-EXCH04.marvell.com> References: <1462460902-25439-1-git-send-email-akarwar@marvell.com> <1462460902-25439-3-git-send-email-akarwar@marvell.com> <20160505162238.44f7ed6d@lxorguk.ukuu.org.uk> In-Reply-To: <20160505162238.44f7ed6d@lxorguk.ukuu.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-05_10:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1605050222 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, > From: One Thousand Gnomes [mailto:gnomes@lxorguk.ukuu.org.uk] > Sent: Thursday, May 05, 2016 8:53 PM > To: Amitkumar Karwar > Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org; > Ganapathi Bhat > Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware > download for Marvell > > > +/* Send ACK/NAK to the device */ > > +static void mrvl_send_ack(struct hci_uart *hu, unsigned char ack) { > > + struct tty_struct *tty = hu->tty; > > + > > + tty->ops->write(tty, &ack, sizeof(ack)); } > > You don't know if the device has a write method, and it should be > locked. > This should go via your ldisc not directly. > Thanks for review. We will take care of this. Regards, Amitkumar