From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936687AbdAEI5N (ORCPT ); Thu, 5 Jan 2017 03:57:13 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59598 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935820AbdAEIzo (ORCPT ); Thu, 5 Jan 2017 03:55:44 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 7B8DE60213 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: sboyd@codeaurora.org, mturquette@baylibre.com Cc: andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Vivek Gautam , Georgi Djakov Subject: [PATCH] clk: qcom: Fix a possible NULL pointer dereferencing Date: Thu, 5 Jan 2017 14:25:25 +0530 Message-Id: <1483606525-27709-1-git-send-email-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assign num_parents as 0 while registering fixed rate clocks in _qcom_cc_register_board_clk(), to make sure the clk framework doesn't dereference parent. Fixes: ee15faffef11 ("clk: qcom: common: Add API to register board clocks backwards compatibly") Cc: Georgi Djakov Signed-off-by: Vivek Gautam --- Based on 'clk-next'. Build tested. drivers/clk/qcom/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index cfab7b400381..df004ead1bef 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -157,6 +157,7 @@ static int _qcom_cc_register_board_clk(struct device *dev, const char *path, init_data.name = path; init_data.ops = &clk_fixed_rate_ops; + init_data.num_parents = 0; ret = devm_clk_hw_register(dev, &fixed->hw); if (ret) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project