From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1162893AbdAFKx3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 05:53:29 -0500
Received: from mout.gmx.net ([212.227.17.20]:62231 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1034925AbdAFKxR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 05:53:17 -0500
Message-ID: <1483699979.11478.21.camel@gmx.de>
Subject: Re: [rfc patch-rt] radix-tree: Partially disable memcg accounting
 in radix_tree_node_alloc()
From: Mike Galbraith <efault@gmx.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rt-users <linux-rt-users@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Date: Fri, 06 Jan 2017 11:52:59 +0100
In-Reply-To: <20170106085548.GD5556@dhcp22.suse.cz>
References: <20161223163213.szj43nv7rnelkbty@linutronix.de>
         <1483690403.11478.8.camel@gmx.de> <20170106085548.GD5556@dhcp22.suse.cz>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:Xz+EvntYkUCdP2vYVD8p+L/goezlSDSDqOm9KXusB8K5mg6GivH
 pldrY5q01ZMBkiJZfob+h3zSwEpn03JG8YPxi71oSkMsD3Kx5LuSjo+MMESaJN9W9LbG0F0
 0nrYlNCwnVdMA97tN3T+q4/xJ7ryUiChopb8ivhgIpjBMTHjN+VUEfCXyF8rNnbjCQhweBq
 wPFGFdggVIyuvhZRVRdNA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pTEQzqSsYJY=:qvnoTM5B+hTjlAISIZEQeF
 5Bf4p/vm0IEgeqe8Pv5Ay3kDhOct47gQnMuW0v17Aa1aT4moaTLFnTCwN92U2ctE7QskZXVSb
 0SaDx/Re/JJctddvdC2OmAJlQNCmeK7Cx/VzhiHDuKojI8gyN7U2ZIUUQO5qAXAalD5pXVx0D
 GrLcgxqJfUceejFnMHnPfjriZf4UTPmc4wbB5IGKnZuQy8eqf2fCfFF48bGMApGHRaXBV2l3P
 4owzeBTEeWbYcBaDgajeJNipnQWLOo4INaG1ideiNYdbgbBPNWU+FKrZyrhtUm7U9PX52blPC
 IkE5bpgrcGBdHHj/xyqlONmGSGPpYmIgyENHH4RYJ/yRWH89PjVzoN5jgbQO7z79E74W3k2px
 litdVobXDry5tS/8dwi6pOvF/svXRug82zPkauX6ei1rbtN1SeE+vMwD98BaGThymj2ezN/Vo
 FGgW7ZEb8X3BdwYL17TLGVlzPCTGwFpuN2tSmZIKy9wWvG8XrJYyLhvyiVPcR5i/AigF8hocX
 G8yyTco9NoE6zR98JLEgt/EYnyXEWgqtyvxgdKWgFm6q//caFL1zMg7Rto6aMoSjyxM4TAATI
 O7qnxXatJNT4sWFZlHaYfHZFzpaLYDAD6jwuiKqIgZWR47MlZSsFtE+QxfFvMQejqOKAG5fav
 /gfRLoAa7P6cAchelKR06dq2Z/5r9enmcVU5D4uwxuPqW2bZ7WEJPuoyA/cw5Sh8b3Sd8Gws9
 D3x6UfLEE9QJjJtqekgHF9cATF7AYs7P92bSlEzctTeypH2GpO4GMXDEFikWWRiuysUNUqV8r
 5V9BoMl
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-01-06 at 09:55 +0100, Michal Hocko wrote:
> On Fri 06-01-17 09:13:23, Mike Galbraith wrote:
> > radix-tree: Partially disable memcg accounting in radix_tree_node_alloc()
> > 
> > Having no preload, which turns accounting off for non-rt kernels, trying to
> > allocate coming from shmem_fault() when memcg is full sends us scurrying off
> > to pagefault_out_of_memory(), with dramatic (usually terminal) consequences.
> > LTP's madvise06 testcase triggers this quite well, and per gitk, the below
> > was the beginning of RT memcg woes.
> > 
> > 58e698af4c63 radix-tree: account radix_tree_node to memory cgroup
> > 
> > Turn memcg accounting off for RT in the problematic path.
> 
> I am really wondering why this is RT specific and the non RT kernels
> doesn't have any problem.

For all I know, there may be a scenario for non-RT to explode, but the
madvise06 testcase that thoroughly nails RT ain't it.

	-Mike