From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033180AbdAFWSn (ORCPT ); Fri, 6 Jan 2017 17:18:43 -0500 Received: from mail-io0-f174.google.com ([209.85.223.174]:32991 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937823AbdAFWSQ (ORCPT ); Fri, 6 Jan 2017 17:18:16 -0500 From: Laura Abbott To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa Cc: Laura Abbott , Alexander Shishkin , linux-kernel@vger.kernel.org Subject: [PATCH] perf tools: Create libdir directory before installing libperf-jvmti.so Date: Fri, 6 Jan 2017 14:18:08 -0800 Message-Id: <1483741088-13543-1-git-send-email-labbott@redhat.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The install command for libperf-jvmti.so does not check if libdir exists before installing. This means that when the install command is run: install libperf-jvmti.so '/tmp/test_root/usr/lib64'; libperf-jvmti.so will get installed to /usr/lib64 as a file and break further installation. Fix this by ensuring the directory gets created first. See https://bugzilla.redhat.com/show_bug.cgi?id=1410296 Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build") Signed-off-by: Laura Abbott --- For full disclosure, Fedora is setting NO_JVMTI but this should still be fixed to allow it to be turned on in the future. --- tools/perf/Makefile.perf | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 8fc2482..7db8ff0 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -661,6 +661,7 @@ ifndef NO_PERF_READ_VDSOX32 endif ifndef NO_JVMTI $(call QUIET_INSTALL, $(LIBJVMTI)) \ + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(libdir_SQ)'; \ $(INSTALL) $(OUTPUT)$(LIBJVMTI) '$(DESTDIR_SQ)$(libdir_SQ)'; endif $(call QUIET_INSTALL, libexec) \ -- 2.7.4