From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S969718AbdAFXY0 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 18:24:26 -0500
Received: from mail-pg0-f66.google.com ([74.125.83.66]:34717 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S969661AbdAFXYR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 18:24:17 -0500
Message-ID: <1483744559.9712.47.camel@edumazet-glaptop3.roam.corp.google.com>
Subject: Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sainath Grandhi <sainath.grandhi@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mahesh@bandewar.net,
        linux-kernel@vger.kernel.org
Date: Fri, 06 Jan 2017 15:15:59 -0800
In-Reply-To: <1483742009-19184-6-git-send-email-sainath.grandhi@intel.com>
References: <1483742009-19184-1-git-send-email-sainath.grandhi@intel.com>
         <1483742009-19184-6-git-send-email-sainath.grandhi@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote:

> +static int tap_list_add(dev_t major, const char *device_name)
> +{
> +	int err = 0;
> +	struct major_info *tap_major;
> +
> +	tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC);
> +
> +	tap_major->major = MAJOR(major);
> +


kzalloc() can perfectly return NULL.

You do not want to crash it that happens.