From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/4] afs: Refcount afs_call struct
Date: Mon, 09 Jan 2017 14:52:49 +0000 [thread overview]
Message-ID: <148397356909.20445.15077871371099721338.stgit@warthog.procyon.org.uk> (raw)
These patches provide some tracepoints for AFS and fix a potential leak by
adding refcounting to the afs_call struct.
The patches are:
(1) Add some tracepoints for logging incoming calls and monitoring
notifications from AF_RXRPC and data reception.
(2) Get rid of afs_wait_mode as it didn't turn out to be as useful as
initially expected. It can be brought back later if needed. This
clears some stuff out that I don't then need to fix up in (4).
(3) Allow listen(..., 0) to be used to disable listening. This makes
shutting down the AFS cache manager server in the kernel much easier
and the accounting simpler as we can then be sure that (a) all
preallocated afs_call structs are relesed and (b) no new incoming
calls are going to be started.
For the moment, listening cannot be reenabled.
(4) Add refcounting to the afs_call struct to fix a potential multiple
release detected by static checking and add a tracepoint to follow the
lifecycle of afs_call objects.
The patches can be found here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite
Tagged thusly:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
rxrpc-rewrite-20170109
David
---
David Howells (4):
afs: Add some tracepoints
afs: Kill afs_wait_mode
rxrpc: Allow listen(sock, 0) to be used to disable listening
afs: Refcount the afs_call struct
fs/afs/callback.c | 2
fs/afs/cmservice.c | 63 ++++++++-----
fs/afs/fsclient.c | 80 ++++++++---------
fs/afs/internal.h | 96 ++++++++------------
fs/afs/main.c | 1
fs/afs/rxrpc.c | 208 +++++++++++++++++++++++---------------------
fs/afs/vlclient.c | 8 +-
fs/afs/vlocation.c | 4 -
fs/afs/vnode.c | 26 +++---
include/trace/events/afs.h | 184 +++++++++++++++++++++++++++++++++++++++
net/rxrpc/af_rxrpc.c | 8 ++
net/rxrpc/ar-internal.h | 1
net/rxrpc/call_accept.c | 3 -
13 files changed, 442 insertions(+), 242 deletions(-)
create mode 100644 include/trace/events/afs.h
next reply other threads:[~2017-01-09 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:52 David Howells [this message]
2017-01-09 14:52 ` [PATCH net-next 1/4] afs: Add some tracepoints David Howells
2017-01-09 14:53 ` [PATCH net-next 2/4] afs: Kill afs_wait_mode David Howells
2017-01-09 14:53 ` [PATCH net-next 3/4] rxrpc: Allow listen(sock, 0) to be used to disable listening David Howells
2017-01-09 14:53 ` [PATCH net-next 4/4] afs: Refcount the afs_call struct David Howells
2017-01-09 20:48 ` [PATCH net-next 0/4] afs: Refcount " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148397356909.20445.15077871371099721338.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®