From: Jike Song <jike.song@intel.com>
To: alex.williamson@redhat.com, serge@hallyn.com
Cc: kwankhede@nvidia.com, kraxel@redhat.com,
linux-security-module@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Jike Song <jike.song@intel.com>
Subject: [v2 2/2] vfio iommu type1: fix the testing of capability for remote task
Date: Thu, 12 Jan 2017 16:52:03 +0800 [thread overview]
Message-ID: <1484211123-8139-3-git-send-email-jike.song@intel.com> (raw)
In-Reply-To: <1484211123-8139-1-git-send-email-jike.song@intel.com>
Before the mdev enhancement type1 iommu used capable() to test the
capability of current task; in the course of mdev development a
new requirement, testing for another task other than current, was
raised. ns_capable() was used for this purpose, however it still
tests current, the only difference is, in a specified namespace.
Fix it by using has_capability() instead, which tests the cap for
specified task in init_user_ns, the same namespace as capable().
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Jike Song <jike.song@intel.com>
---
drivers/vfio/vfio_iommu_type1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 9266271..77373e5 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -495,8 +495,7 @@ static int vfio_pin_page_external(struct vfio_dma *dma, unsigned long vaddr,
unsigned long *pfn_base, bool do_accounting)
{
unsigned long limit;
- bool lock_cap = ns_capable(task_active_pid_ns(dma->task)->user_ns,
- CAP_IPC_LOCK);
+ bool lock_cap = has_capability(dma->task, CAP_IPC_LOCK);
struct mm_struct *mm;
int ret;
bool rsvd;
--
1.9.3
next prev parent reply other threads:[~2017-01-12 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 8:52 [v2 0/2] test " Jike Song
2017-01-12 8:52 ` [v2 1/2] capability: export has_capability Jike Song
2017-01-12 22:22 ` James Morris
2017-01-12 8:52 ` Jike Song [this message]
2017-01-12 22:22 ` [v2 2/2] vfio iommu type1: fix the testing of capability for remote task James Morris
2017-01-13 6:52 ` Kirti Wankhede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484211123-8139-3-git-send-email-jike.song@intel.com \
--to=jike.song@intel.com \
--cc=alex.williamson@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®