From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751263AbdALKz1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Jan 2017 05:55:27 -0500
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48577 "EHLO
        metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750804AbdALKzY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jan 2017 05:55:24 -0500
Message-ID: <1484218444.2376.9.camel@pengutronix.de>
Subject: Re: [PATCH] reset: constify reset_control_ops structures
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, linux-kernel@vger.kernel.org
Date: Thu, 12 Jan 2017 11:54:04 +0100
In-Reply-To: <1483980835-13659-1-git-send-email-bhumirks@gmail.com>
References: <1483980835-13659-1-git-send-email-bhumirks@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Montag, den 09.01.2017, 22:23 +0530 schrieb Bhumika Goyal:
> Declare reset_control_ops structures as const as they are only stored
> in the ops field of a reset_controller_dev structure. This field is of
> type const struct reset_control_ops *, so reset_control_ops structures
> having this property can be declared as const.
> Done using Coccinelle:
> 
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@p={...};
> 
> @ok1@
> identifier r1.i;
> position p;
> struct ti_syscon_reset_data data;
> @@
> data.rcdev.ops=&i@p;
> 
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
> 
> File size before: drivers/reset/reset-ti-syscon.o
>    text	   data	    bss	    dec	    hex	filename
>    1329	    240	      0	   1569	    621	drivers/reset/reset-ti-syscon.o
> 
> File size after: drivers/reset/reset-ti-syscon.o
>    text	   data	    bss	    dec	    hex	filename
>    1377	    192	      0	   1569	    621	drivers/reset/reset-ti-syscon.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied, thank you.

regards
Philipp