From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751214AbdALQcc (ORCPT ); Thu, 12 Jan 2017 11:32:32 -0500 Received: from www.osadl.org ([62.245.132.105]:53514 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdALQca (ORCPT ); Thu, 12 Jan 2017 11:32:30 -0500 From: Nicholas Mc Guire To: John Youn Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH V2] usb: dwc2: host: fix Wmaybe-uninitialized warning Date: Thu, 12 Jan 2017 17:33:26 +0100 Message-Id: <1484238806-13977-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uninitialized char* causes a sparse build-warning, fix it up by initializing it to NULL. Signed-off-by: Nicholas Mc Guire --- V2: add missing change-log as requested by Greg Kroah-Hartman Problem reported by sparse drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info': ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized] __dynamic_dev_dbg(&descriptor, dev, fmt, \ ^ drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here char *pipetype; ^ Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m + CONFIG_USB_DWC2_VERBOSE=y Patch is against 4.10-rc3 (localversion-next is next-20170112) drivers/usb/dwc2/hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 911c3b3..9f66777 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -4489,8 +4489,8 @@ static void dwc2_dump_urb_info(struct usb_hcd *hcd, struct urb *urb, { #ifdef VERBOSE_DEBUG struct dwc2_hsotg *hsotg = dwc2_hcd_to_hsotg(hcd); - char *pipetype; - char *speed; + char *pipetype = NULL; + char *speed = NULL; dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb); dev_vdbg(hsotg->dev, " Device address: %d\n", -- 2.1.4