mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v2 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data
Date: Fri, 13 Jan 2017 10:34:05 -0300	[thread overview]
Message-ID: <1484314449-10060-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1484314449-10060-1-git-send-email-javier@osg.samsung.com>

The driver is only used in platforms that have DT support so always the
I2C device .data will be get from the matched OF node and never will be
from the I2C device ID table.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes in v2:
- Add Laxman's Acked-by tag to patch 1/4.
- Add Krzysztof's Reviewed-by and Tested-by tags to patch 1/4.

 drivers/mfd/max77686.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 7b68ed72e9cb..ddae3bf3e46c 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -188,14 +188,11 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
 	if (!max77686)
 		return -ENOMEM;
 
-	if (i2c->dev.of_node) {
-		match = of_match_node(max77686_pmic_dt_match, i2c->dev.of_node);
-		if (!match)
-			return -EINVAL;
-
-		max77686->type = (unsigned long)match->data;
-	} else
-		max77686->type = id->driver_data;
+	match = of_match_node(max77686_pmic_dt_match, i2c->dev.of_node);
+	if (!match)
+		return -EINVAL;
+
+	max77686->type = (unsigned long)match->data;
 
 	i2c_set_clientdata(i2c, max77686);
 	max77686->dev = &i2c->dev;
-- 
2.7.4

  reply	other threads:[~2017-01-13 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 13:34 [PATCH v2 0/4] mfd: max77686: Remove unneeded non-OF code in driver Javier Martinez Canillas
2017-01-13 13:34 ` Javier Martinez Canillas [this message]
2017-01-16  6:30   ` [PATCH v2 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data Chanwoo Choi
2017-01-23 11:35   ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper Javier Martinez Canillas
2017-01-13 14:09   ` Krzysztof Kozlowski
2017-01-16  6:34   ` Chanwoo Choi
2017-01-23 11:36   ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Javier Martinez Canillas
2017-01-16  6:37   ` Chanwoo Choi
2017-01-23 11:36   ` Lee Jones
2017-01-13 13:34 ` [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas
2017-01-16  6:46   ` Chanwoo Choi
2017-01-16 12:30     ` Javier Martinez Canillas
2017-01-23 11:39       ` Lee Jones
2017-01-23 11:40   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484314449-10060-2-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®