From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdAMNeo (ORCPT ); Fri, 13 Jan 2017 08:34:44 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50515 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbdAMNel (ORCPT ); Fri, 13 Jan 2017 08:34:41 -0500 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Laxman Dewangan , Javier Martinez Canillas , Krzysztof Kozlowski , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Lee Jones Subject: [PATCH v2 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Date: Fri, 13 Jan 2017 10:34:07 -0300 Message-Id: <1484314449-10060-4-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a driver is only used in DT platforms, there's no need to get the i2c_device_id as an argument of the probe function. Since this data can be get from the matching of_device_id. There's a temporary .probe_new field in struct i2c_driver that can be used as probe callback for the case when i2c_device_id won't be used. Signed-off-by: Javier Martinez Canillas Acked-by: Laxman Dewangan Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski --- Changes in v2: - Add Laxman's Acked-by tag to patch 3/4. - Add Krzysztof's Reviewed-by and Tested-by tags to patch 3/4. drivers/mfd/max77686.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 33dd09493605..896c1bf85acc 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -172,8 +172,7 @@ static const struct of_device_id max77686_pmic_dt_match[] = { }; MODULE_DEVICE_TABLE(of, max77686_pmic_dt_match); -static int max77686_i2c_probe(struct i2c_client *i2c, - const struct i2c_device_id *id) +static int max77686_i2c_probe(struct i2c_client *i2c) { struct max77686_dev *max77686 = NULL; unsigned int data; @@ -294,7 +293,7 @@ static struct i2c_driver max77686_i2c_driver = { .pm = &max77686_pm, .of_match_table = of_match_ptr(max77686_pmic_dt_match), }, - .probe = max77686_i2c_probe, + .probe_new = max77686_i2c_probe, .id_table = max77686_i2c_id, }; -- 2.7.4