From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751125AbdAMTCa (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 14:02:30 -0500
Received: from mail-pf0-f194.google.com ([209.85.192.194]:35996 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750760AbdAMTC3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 14:02:29 -0500
Message-ID: <1484334145.13165.49.camel@edumazet-glaptop3.roam.corp.google.com>
Subject: Re: [PATCH][V2] flow dissector: check if arp_eth is null rather
 than arp
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
        Alexander Duyck <aduyck@mirantis.com>, Jiri Pirko <jiri@mellanox.com>,
        Tom Herbert <tom@herbertland.com>, Eric Dumazet <edumazet@google.com>,
        Hadar Hen Zion <hadarh@mellanox.com>,
        Simon Horman <simon.horman@netronome.com>,
        Gao Feng <fgao@48lvckh6395k16k5.yundunddos.com>,
        Amir Vadai <amir@vadai.me>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 13 Jan 2017 11:02:25 -0800
In-Reply-To: <20170113184820.823-1-colin.king@canonical.com>
References: <20170113184820.823-1-colin.king@canonical.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-01-13 at 18:48 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> arp is being checked instead of arp_eth to see if the call to
> __skb_header_pointer failed. Fix this by checking arp_eth is
> null instead of arp.   Also fix to use length hlen rather than
> hlen - sizeof(_arp); thanks to Eric Dumazet for spotting
> this latter issue.
> 
> CoverityScan CID#1396428 ("Logically dead code") on 2nd
> arp comparison (which should be arp_eth instead).
> 
> Fixes: commit 55733350e5e8b70c5 ("flow disector: ARP support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Acked-by: Eric Dumazet <edumazet@google.com>

Thanks !