From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751112AbdAOMwU (ORCPT ); Sun, 15 Jan 2017 07:52:20 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33080 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdAOMwT (ORCPT ); Sun, 15 Jan 2017 07:52:19 -0500 From: Shyam Saini To: gregkh@linuxfoundation.org Cc: binoy.jayan@linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shyam Saini Subject: [PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree Date: Sun, 15 Jan 2017 18:21:46 +0530 Message-Id: <1484484706-6633-1-git-send-email-mayhs11saini@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree. Signed-off-by: Shyam Saini --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 8a9172a..4bf7041 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2695,10 +2695,8 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev) priv->polling_timer_on = 0; _rtl92e_down(dev, true); rtl92e_dm_deinit(dev); - if (priv->pFirmware) { - vfree(priv->pFirmware); - priv->pFirmware = NULL; - } + vfree(priv->pFirmware); + priv->pFirmware = NULL; _rtl92e_free_rx_ring(dev); for (i = 0; i < MAX_TX_QUEUE_COUNT; i++) _rtl92e_free_tx_ring(dev, i); -- 2.7.4