From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751199AbdAPJeX (ORCPT ); Mon, 16 Jan 2017 04:34:23 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34985 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdAPJeU (ORCPT ); Mon, 16 Jan 2017 04:34:20 -0500 Message-ID: <1484559248.30810.71.camel@pengutronix.de> Subject: Re: [PATCH] drm: etnaviv: constify etnaviv_iommu_ops structures From: Lucas Stach To: Bhumika Goyal Cc: julia.lawall@lip6.fr, etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, airlied@linux.ie, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 16 Jan 2017 10:34:08 +0100 In-Reply-To: <1484506228-16777-1-git-send-email-bhumirks@gmail.com> References: <1484506228-16777-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 16.01.2017, 00:20 +0530 schrieb Bhumika Goyal: > Declare etnaviv_iommu_ops structure as const as it is only used when > the reference of one of its field is stored in the ops field of a > iommu_domain structure. This ops field is of type const, so > etnaviv_iommu_ops structures having similar properties can be declared > const too. > Done using Coccinelle: > > @r1 disable optional_qualifier@ > identifier i; > position p; > @@ > static struct etnaviv_iommu_ops i@p={...}; > > @ok1@ > identifier r1.i; > position p; > struct etnaviv_iommu_domain x; > @@ > x.domain.ops=&i@p.ops; > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct etnaviv_iommu_ops i; > > Before and after size details of .o file remains the same after > cross compiling for arm architecture. > > Signed-off-by: Bhumika Goyal Thanks, I've applied this patch to my tree. > --- > drivers/gpu/drm/etnaviv/etnaviv_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu.c > index 81f1583..7a7c97f 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu.c > @@ -184,7 +184,7 @@ static void etnaviv_iommuv1_dump(struct iommu_domain *domain, void *buf) > memcpy(buf, etnaviv_domain->pgtable.pgtable, PT_SIZE); > } > > -static struct etnaviv_iommu_ops etnaviv_iommu_ops = { > +static const struct etnaviv_iommu_ops etnaviv_iommu_ops = { > .ops = { > .domain_free = etnaviv_domain_free, > .map = etnaviv_iommuv1_map,