From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbdAPJpc (ORCPT ); Mon, 16 Jan 2017 04:45:32 -0500 Received: from mail.quarkslab.com ([195.154.215.101]:53635 "EHLO mail.quarkslab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdAPJpc (ORCPT ); Mon, 16 Jan 2017 04:45:32 -0500 From: "G. Campana" To: Amit Shah Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "G. Campana" Subject: [PATCH v2] virtio_console: fix a crash in config_work_handler Date: Mon, 16 Jan 2017 10:45:02 +0100 Message-Id: <1484559902-5346-1-git-send-email-gcampana@quarkslab.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20170116033550.GK16209@amit-lp.rh> References: <20170116033550.GK16209@amit-lp.rh> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using control_work instead of config_work as the 3rd argument to container_of results in an invalid portdev pointer. Indeed, the work structure is initialized as below: INIT_WORK(&portdev->config_work, &config_work_handler); It leads to a crash when portdev->vdev is dereferenced later. This bug is triggered when the guest uses a virtio-console without multiport feature and receives a config_changed virtio interrupt. Signed-off-by: G. Campana --- drivers/char/virtio_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 8b00e79..17857be 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1862,7 +1862,7 @@ static void config_work_handler(struct work_struct *work) { struct ports_device *portdev; - portdev = container_of(work, struct ports_device, control_work); + portdev = container_of(work, struct ports_device, config_work); if (!use_multiport(portdev)) { struct virtio_device *vdev; struct port *port; -- 2.7.4