mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ulrich Hecht <uli@fpond.eu>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>
Cc: Julia Lawall <julia.lawall@inria.fr>,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas
Date: Tue, 21 Sep 2021 12:52:44 +0200 (CEST)	[thread overview]
Message-ID: <1484614497.1401661.1632221564869@webmail.strato.com> (raw)
In-Reply-To: <b1710bb6ea5faa7a7fe74404adb0beb951e0bf8c.1631699160.git.geert+renesas@glider.be>


> On 09/15/2021 11:47 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> 
>  
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
> 
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/irqchip/irq-renesas-rza1.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renesas-rza1.c
> index b0d46ac42b892340..72c06e883d1c5fd5 100644
> --- a/drivers/irqchip/irq-renesas-rza1.c
> +++ b/drivers/irqchip/irq-renesas-rza1.c
> @@ -223,12 +223,12 @@ static int rza1_irqc_probe(struct platform_device *pdev)
>  		goto out_put_node;
>  	}
>  
> -	priv->chip.name = "rza1-irqc",
> -	priv->chip.irq_mask = irq_chip_mask_parent,
> -	priv->chip.irq_unmask = irq_chip_unmask_parent,
> -	priv->chip.irq_eoi = rza1_irqc_eoi,
> -	priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy,
> -	priv->chip.irq_set_type = rza1_irqc_set_type,
> +	priv->chip.name = "rza1-irqc";
> +	priv->chip.irq_mask = irq_chip_mask_parent;
> +	priv->chip.irq_unmask = irq_chip_unmask_parent;
> +	priv->chip.irq_eoi = rza1_irqc_eoi;
> +	priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy;
> +	priv->chip.irq_set_type = rza1_irqc_set_type;
>  	priv->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE;
>  
>  	priv->irq_domain = irq_domain_add_hierarchy(parent, 0, IRQC_NUM_IRQ,
> -- 
> 2.25.1

Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>

CU
Uli

      reply	other threads:[~2021-09-21 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:47 Geert Uytterhoeven
2021-09-21 10:52 ` Ulrich Hecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484614497.1401661.1632221564869@webmail.strato.com \
    --to=uli@fpond.eu \
    --cc=geert+renesas@glider.be \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®