From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Dhananjay Balan <dhananjay@cliqz.com>
Cc: Stuart Yoder <stuart.yoder@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fsl-mc: fix coding stye errors
Date: Tue, 17 Jan 2017 00:47:30 -0800 [thread overview]
Message-ID: <1484642850.9538.7.camel@perches.com> (raw)
In-Reply-To: <20170117082708.GC4051@mwanda>
On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > Split line at boolean operator.
> >
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
[]
> > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
[]
> > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void)
> > continue;
> > }
> >
> > - WARN_ON(mc_msi_domain->
> > - host_data != &its_fsl_mc_msi_domain_info);
> > + WARN_ON(mc_msi_domain->host_data !=
> > + &its_fsl_mc_msi_domain_info);
>
> Better to line it up like this:
>
> WARN_ON(mc_msi_domain->host_data !=
> &its_fsl_mc_msi_domain_info);
At 81 chars, it might be better on a single line instead.
WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info);
It also might be better to shorten some of the identifiers.
next prev parent reply other threads:[~2017-01-17 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 8:11 Dhananjay Balan
2017-01-17 8:27 ` Dan Carpenter
2017-01-17 8:47 ` Joe Perches [this message]
2017-01-17 10:00 ` Dan Carpenter
2017-01-18 10:53 ` [PATCH v2] " Dhananjay Balan
2017-01-18 11:14 ` Greg KH
2017-01-18 17:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484642850.9538.7.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhananjay@cliqz.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome