From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753917AbdASQqC (ORCPT ); Thu, 19 Jan 2017 11:46:02 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:44415 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbdASQoe (ORCPT ); Thu, 19 Jan 2017 11:44:34 -0500 Message-ID: <1484844267.24339.44.camel@pengutronix.de> Subject: Re: [PATCH 2/3] PCI: imx6: Allow probe deferal by reset GPIO From: Lucas Stach To: Andrey Smirnov Cc: linux-pci@vger.kernel.org, yurovsky@gmail.com, Richard Zhu , Bjorn Helgaas , Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 19 Jan 2017 17:44:27 +0100 In-Reply-To: <20170119163631.10668-3-andrew.smirnov@gmail.com> References: <20170119163631.10668-1-andrew.smirnov@gmail.com> <20170119163631.10668-3-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 19.01.2017, 08:36 -0800 schrieb Andrey Smirnov: > Some designs implement reset GPIO via a GPIO expander connected to a > peripheral bus. One such example would be i.MX7 Sabre board where said > GPIO is provided by SPI shift register connected to a bitbanged SPI > bus. In order to support such designs allow reset GPIO request to defer > probing of the driver. > > Cc: yurovsky@gmail.com > Cc: Richard Zhu > Cc: Lucas Stach > Cc: Bjorn Helgaas > Cc: Fabio Estevam > Cc: Shawn Guo > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andrey Smirnov > --- > drivers/pci/host/pci-imx6.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > index 50a1291..574f026 100644 > --- a/drivers/pci/host/pci-imx6.c > +++ b/drivers/pci/host/pci-imx6.c > @@ -653,6 +653,9 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) > dev_err(dev, "unable to get reset gpio\n"); > return ret; > } > + } else if (imx6_pcie->reset_gpio == -EPROBE_DEFER) { > + dev_info(dev, "probe is defered by reset GPIO\n"); No, please no messages for probe deferrals, as those might happen quite often until the required driver is there and then just spams the logs. Otherwise looks good. > + return imx6_pcie->reset_gpio; > } > > /* Fetch clocks */ > @@ -746,11 +749,12 @@ static struct platform_driver imx6_pcie_driver = { > .name = "imx6q-pcie", > .of_match_table = imx6_pcie_of_match, > }, > + .probe = imx6_pcie_probe, > .shutdown = imx6_pcie_shutdown, > }; > > static int __init imx6_pcie_init(void) > { > - return platform_driver_probe(&imx6_pcie_driver, imx6_pcie_probe); > + return platform_driver_register(&imx6_pcie_driver); > } > device_initcall(imx6_pcie_init);