From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754570AbdASTqu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Jan 2017 14:46:50 -0500
Received: from mga06.intel.com ([134.134.136.31]:50100 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754417AbdASTqs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Jan 2017 14:46:48 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,255,1477983600"; 
   d="scan'208";a="32846794"
Message-ID: <1484855022.2833.36.camel@linux.intel.com>
Subject: Re: [PATCH v2] platform: x86: Support Turbo Boost Max 3.0 for non
 HWP systems
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        dvhart@infradead.org
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 19 Jan 2017 11:43:42 -0800
In-Reply-To: <1484822314.2133.222.camel@linux.intel.com>
References: <1484764155-183890-1-git-send-email-srinivas.pandruvada@linux.intel.com>
         <1484779250.2833.34.camel@linux.intel.com>
         <1484822314.2133.222.camel@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-01-19 at 12:38 +0200, Andy Shevchenko wrote:
> On Wed, 2017-01-18 at 14:40 -0800, Tim Chen wrote:
> > 
> > On Wed, 2017-01-18 at 10:29 -0800, Srinivas Pandruvada wrote:
> > > 
> > >  
> > > +
> > > +static int itmt_legacy_cpu_online(unsigned int cpu)
> > > +{
> > > +	static u32 max_highest_perf = 0, min_highest_perf =
> > > U32_MAX;
> > Should the max_highest_perf and min_highest_perf be defined and
> > initialized
> > outside this function?  Otherwise the max and min value will be lost
> > and reset
> > each time a new cpu comes online.
> > 
> > We will always find max_highest_perf == min_highest_perf.
> Perhaps you missed static keyword there. Their behaviour is the same as
> for global variables, i.e. the initial value assigned only at the
> beginning.
> 

Yes I did miss the static modifier. Sorry for the noise.

Tim