From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753718AbdATAH3 (ORCPT ); Thu, 19 Jan 2017 19:07:29 -0500 Received: from smtprelay0238.hostedemail.com ([216.40.44.238]:33980 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753522AbdATAHY (ORCPT ); Thu, 19 Jan 2017 19:07:24 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1605:1711:1730:1747:1777:1792:2393:2525:2553:2566:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6119:6120:7903:7974:8599:8985:9010:9025:9040:9388:10004:10049:10400:10450:10455:10848:11232:11658:11914:12043:12555:12663:12696:12737:12740:12760:12895:12933:12986:13095:13437:13439:14093:14096:14097:14181:14659:14721:14849:19904:19999:21080:21212:21324:21325:21433:21451:30012:30029:30030:30054:30060:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: part65_715a1da5e2b11 X-Filterd-Recvd-Size: 3868 Message-ID: <1484870777.2707.2.camel@perches.com> Subject: Re: [RFC for GIT] pull-request: add praise to people doing QA From: Joe Perches To: Jacob Keller , Jeff King Cc: Wolfram Sang , Junio C Hamano , Git mailing list , "linux-kernel@vger.kernel.org" Date: Thu, 19 Jan 2017 16:06:17 -0800 In-Reply-To: References: <20170115183051.3565-1-wsa@the-dreams.de> <20170119204343.xtotmjddhbum2mvr@ninjato> <20170119212039.3gixsrk7qco45wjo@sigill.intra.peff.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-01-19 at 15:42 -0800, Jacob Keller wrote: > On Thu, Jan 19, 2017 at 1:20 PM, Jeff King wrote: > > On Thu, Jan 19, 2017 at 09:43:45PM +0100, Wolfram Sang wrote: > > > > > > As to the implementation, I am wondering if we can make this somehow > > > > work well with the "trailers" code we already have, instead of > > > > inventing yet another parser of trailers. > > > > > > > > In its current shape, "interpret-trailers" focuses on "editing" an > > > > existing commit log message to tweak the trailer lines. That mode > > > > of operation would help amending and rebasing, and to do that it > > > > needs to parse the commit log message, identify trailer blocks, > > > > parse out each trailer lines, etc. > > > > > > > > There is no fundamental reason why its output must be an edited > > > > original commit log message---it should be usable as a filter that > > > > picks trailer lines of the selected trailer type, like "Tested-By", > > > > etc. > > > > > > I didn't know about trailers before. As I undestand it, I could use > > > "Tested-by" as the key, and the commit subject as the value. This list > > > then could be parsed and brought into proper output shape. It would > > > simplify the subject parsing, but most things my AWK script currently > > > does would still need to stay or to be reimplemented (extracting names > > > from tags, creating arrays of tags given by $name). Am I correct? > > > > > > All under the assumption that trailers work on a range of commits. I > > > have to admit that adding this to git is beyond my scope. > > > > This sounds a lot like the shortlog-trailers work I did about a year > > ago: > > > > http://public-inbox.org/git/20151229073832.GN8842@sigill.intra.peff.net/ > > > > http://public-inbox.org/git/20151229075013.GA9191@sigill.intra.peff.net/ > > > > Nobody seemed to really find it useful, so I didn't pursue it. > > > > Some of the preparatory patches in that series bit-rotted in the > > meantime, but you can play with a version based on v2.7.0 by fetching > > the "shortlog-trailers-historical" branch from > > https://github.com/peff/git.git. > > > > And then things like: > > > > git shortlog --ident=tested-by --format='...tested a patch by %an' > > > > work (and you can put whatever commit items you want into the --format, > > including just dumping the hash if you want to do more analysis). > > > > -Peff > > This sounds interesting to me! When I have some more time to take a > look at this i might see if I can revive it. Can the terminology please be standardized to what was once called bylines? https://patchwork.kernel.org/patch/9307703/