mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 3/4] perf c2c report: Display Total records column in offset view
Date: Fri, 20 Jan 2017 10:20:31 +0100	[thread overview]
Message-ID: <1484904032-11040-4-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1484904032-11040-1-git-send-email-jolsa@kernel.org>

Adding "Total records" column into cacheline pareto table,
between cycles and cpu info.

  $ perf c2c report
  ...

  ---    ---------- cycles ----------    Total       cpu
         rmt hitm  lcl hitm      load  records       cnt
  ...    ........  ........  ........  .......  ........

                0       112        71       34         4
                0         0         0       18         1
                0         0         0        2         1
                0       132         0        3         3

  ...

It's useful to see how many recorded samples
represent each offset.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-kq06b6zjv3uuy1wfhkm3dewc@git.kernel.org
---
 tools/perf/builtin-c2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index f8ca7a4ebabc..616cb1418c3f 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2476,6 +2476,7 @@ static int build_cl_output(char *cl_sort, bool no_source)
 		"mean_rmt,"
 		"mean_lcl,"
 		"mean_load,"
+		"tot_recs,"
 		"cpucnt,",
 		add_sym ? "symbol," : "",
 		add_dso ? "dso," : "",
-- 
2.7.4

  parent reply	other threads:[~2017-01-20  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20  9:20 [PATCH 0/4] perf tools: Few fixes Jiri Olsa
2017-01-20  9:20 ` [PATCH 1/4] perf hists browser: Put hist_entry folding login into single function Jiri Olsa
2017-01-26 15:26   ` [tip:perf/core] perf hists browser: Put hist_entry folding logic " tip-bot for Jiri Olsa
2017-01-20  9:20 ` [PATCH 2/4] perf hists browser: Add e/c key handlers to expand callchain for current entry Jiri Olsa
2017-01-20 16:41   ` Arnaldo Carvalho de Melo
2017-01-20 16:43     ` Arnaldo Carvalho de Melo
2017-01-23  9:01       ` Jiri Olsa
2017-01-26 15:26   ` [tip:perf/core] perf hists browser: Add e/c hotkeys to expand/collapse " tip-bot for Jiri Olsa
2017-01-20  9:20 ` Jiri Olsa [this message]
2017-01-26 15:27   ` [tip:perf/core] perf c2c report: Display Total records column in offset view tip-bot for Jiri Olsa
2017-01-20  9:20 ` [PATCH 4/4] perf c2c report: Coalesce by default only by pid,iaddr Jiri Olsa
2017-01-26 15:27   ` [tip:perf/core] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484904032-11040-4-git-send-email-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome