From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdAYUuQ (ORCPT ); Wed, 25 Jan 2017 15:50:16 -0500 Received: from mga07.intel.com ([134.134.136.100]:52749 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbdAYUuO (ORCPT ); Wed, 25 Jan 2017 15:50:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,285,1477983600"; d="scan'208";a="35464590" Message-ID: <1485377409.2133.339.camel@linux.intel.com> Subject: Re: [PATCH v3] i2c: core: helper function to detect slave mode From: Andy Shevchenko To: Wolfram Sang , Luis Oliveira Cc: robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vz@mleia.com, Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Wed, 25 Jan 2017 22:50:09 +0200 In-Reply-To: <20170125204537.i66nykln4fkxqryy@ninjato> References: <58edd25a0fbe50b6d5abef14b7e46c63a1e06830.1484663257.git.lolivei@synopsys.com> <20170125204537.i66nykln4fkxqryy@ninjato> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote: > > + * i2c_slave_mode_detect - detect operation mode > > I'd rather name it 'i2c_detect_slave_mode' When I proposed that I kept in ming `git grep -n i2c_slave`. > The code looks good to me, so we are close to go! Thumb up! -- Andy Shevchenko Intel Finland Oy