mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v2 7/8] mfd: exynos-lpass: Add missing remove() function
Date: Thu, 26 Jan 2017 09:33:53 +0100	[thread overview]
Message-ID: <1485419634-28331-8-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1485419634-28331-1-git-send-email-m.szyprowski@samsung.com>

Disable device on driver remove and release allocated regmap.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/mfd/exynos-lpass.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
index be264988bdc9..9dbbedad916f 100644
--- a/drivers/mfd/exynos-lpass.c
+++ b/drivers/mfd/exynos-lpass.c
@@ -137,6 +137,16 @@ static int exynos_lpass_probe(struct platform_device *pdev)
 	return of_platform_populate(dev->of_node, NULL, NULL, dev);
 }
 
+static int exynos_lpass_remove(struct platform_device *pdev)
+{
+	struct exynos_lpass *lpass = platform_get_drvdata(pdev);
+
+	exynos_lpass_disable(lpass);
+	regmap_exit(lpass->top);
+
+	return 0;
+}
+
 static int __maybe_unused exynos_lpass_suspend(struct device *dev)
 {
 	struct exynos_lpass *lpass = dev_get_drvdata(dev);
@@ -171,6 +181,7 @@ static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend,
 		.of_match_table	= exynos_lpass_of_match,
 	},
 	.probe	= exynos_lpass_probe,
+	.remove	= exynos_lpass_remove,
 };
 module_platform_driver(exynos_lpass_driver);
 
-- 
1.9.1

  parent reply	other threads:[~2017-01-26  8:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170126083401eucas1p20b4794fe46ccf2189bf734f0d8e3c536@eucas1p2.samsung.com>
2017-01-26  8:33 ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski
     [not found]   ` <CGME20170126083401eucas1p24b0f04c62332e0b6e446ecca83145bc5@eucas1p2.samsung.com>
2017-01-26  8:33     ` [PATCH v2 1/8] soc: samsung: pmu: Add dummy support for Exynos5433 SoC Marek Szyprowski
2017-01-26 19:57       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170126083401eucas1p289b69e3694b91e83983cd6e09aa7053c@eucas1p2.samsung.com>
2017-01-26  8:33     ` [PATCH v2 2/8] pinctrl: samsung: Ensure that pad retention is disabled on driver init Marek Szyprowski
     [not found]   ` <CGME20170126083402eucas1p187d3d31f62544fc46fae99fc5f74dbfe@eucas1p1.samsung.com>
2017-01-26  8:33     ` [PATCH v2 3/8] pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs Marek Szyprowski
2017-01-26 19:48       ` Krzysztof Kozlowski
2017-01-27 18:02         ` Krzysztof Kozlowski
2017-01-30 10:39           ` Marek Szyprowski
2017-01-26 19:57       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170126083403eucas1p1ad75fe027047dc240b9afd651c7713a5@eucas1p1.samsung.com>
2017-01-26  8:33     ` [PATCH v2 4/8] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Marek Szyprowski
2017-01-26 20:08       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170126083403eucas1p2328ed884334b453ffb1faac3c745cec3@eucas1p2.samsung.com>
2017-01-26  8:33     ` [PATCH v2 5/8] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski
2017-01-26  9:36       ` Sylwester Nawrocki
2017-02-01 13:24       ` Rob Herring
2017-02-08 10:56       ` Lee Jones
     [not found]   ` <CGME20170126083404eucas1p132ce7a0792505367f6a001f21e9d1632@eucas1p1.samsung.com>
2017-01-26  8:33     ` [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Marek Szyprowski
2017-01-26 20:09       ` Krzysztof Kozlowski
2017-02-01 13:24       ` Rob Herring
2017-02-08 10:57       ` Lee Jones
     [not found]   ` <CGME20170126083405eucas1p29a888fa3896e2bd131e23585f7d033d9@eucas1p2.samsung.com>
2017-01-26  8:33     ` Marek Szyprowski [this message]
2017-01-26 20:11       ` [PATCH v2 7/8] mfd: exynos-lpass: Add missing remove() function Krzysztof Kozlowski
2017-02-08 10:57       ` Lee Jones
     [not found]   ` <CGME20170126083406eucas1p20148fa4f3ca70d333400c806dd490aef@eucas1p2.samsung.com>
2017-01-26  8:33     ` [PATCH v2 8/8] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski
2017-02-08 10:58       ` Lee Jones
2017-01-26  9:50   ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Linus Walleij
2017-01-26 10:37     ` Marek Szyprowski
2017-01-26 14:32     ` Krzysztof Kozlowski
2017-01-26 15:47       ` Linus Walleij
2017-01-27 19:46   ` Krzysztof Kozlowski
2017-01-30  9:57     ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485419634-28331-8-git-send-email-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®