From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdAZNAs (ORCPT ); Thu, 26 Jan 2017 08:00:48 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36005 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdAZNAr (ORCPT ); Thu, 26 Jan 2017 08:00:47 -0500 From: Serge Semin To: gregkh@linuxfoundation.org, julia.lawall@lip6.fr Cc: Sergey.Semin@t-platforms.ru, linux-kernel@vger.kernel.org, Serge Semin Subject: [PATCH] eeprom: idt_89hpesx: Discard memory freeing allocated by devm_kmalloc Date: Thu, 26 Jan 2017 16:00:36 +0300 Message-Id: <1485435636-10431-1-git-send-email-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.6.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Indeed, the data structure is allocated by device resource manager, so the driver doesn't need to free anything on remove() callback. Reported-by: Julia Lawall Signed-off-by: Serge Semin --- drivers/misc/eeprom/idt_89hpesx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 25d47d0..f73fd04 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1227,9 +1227,6 @@ static void idt_free_pdev(struct idt_89hpesx_dev *pdev) { /* Clear driver data from device private field */ i2c_set_clientdata(pdev->client, NULL); - - /* Just free memory allocated for data */ - devm_kfree(&pdev->client->dev, pdev); } /* -- 2.6.6