From: Joe Perches <joe@perches.com>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Darren Hart" <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present
Date: Thu, 26 Jan 2017 14:45:41 -0800 [thread overview]
Message-ID: <1485470741.12563.104.camel@perches.com> (raw)
In-Reply-To: <20170126153013.12753-9-jprvita@endlessm.com>
On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
> Some Asus laptops that have an airplane-mode indicator LED, also have
> the WMI WLAN user bit set, and the following bits in their DSDT:
style trivia:
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
[]
> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
> return 0;
> }
>
> +static bool ashs_present(void)
> +{
> + int i;
> +
> + for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
> + if (acpi_dev_found(asus_wireless_ids[i].id))
> + return true;
The for loop would commonly have braces because of the
internal if.
next prev parent reply other threads:[~2017-01-26 22:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:30 [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 1/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 2/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 3/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 4/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 5/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 6/8] Revert "asus-wmi: Create quirk for airplane_mode LED" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 7/8] asus-wireless: Export ids list João Paulo Rechi Vita
2017-01-27 15:36 ` Andy Shevchenko
2017-02-01 12:23 ` João Paulo Rechi Vita
2017-02-04 15:35 ` Andy Shevchenko
2017-02-06 19:18 ` João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present João Paulo Rechi Vita
2017-01-26 22:45 ` Joe Perches [this message]
2017-02-01 12:18 ` João Paulo Rechi Vita
2017-01-27 15:37 ` [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} Andy Shevchenko
2017-02-01 12:21 ` João Paulo Rechi Vita
2017-02-04 15:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485470741.12563.104.camel@perches.com \
--to=joe@perches.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=jprvita@endlessm.com \
--cc=jprvita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome