From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932613AbdA0Kn4 (ORCPT ); Fri, 27 Jan 2017 05:43:56 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:44728 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932586AbdA0Km6 (ORCPT ); Fri, 27 Jan 2017 05:42:58 -0500 X-AuditID: b6c32a37-f79196d000001a39-68-588b242ad4af From: Shailendra Verma To: Rakesh Iyer , Laxman Dewangan , Dmitry Torokhov , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-input@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Input: tegra-kbc - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:12:36 +0530 Message-id: <1485513756-1854-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsWy7bCmvq6WSneEwZ2Zqhb3p31jtzi86AWj xblXj1gslu5bzWJx89M3VovLu+awWXR+mcVmsWNKK4vFj0k/2C1uzZvJZrHo2ytmi1cH21gs fu6ax2Lx9+IlNgc+j52z7rJ79Da/Y/Po27KK0ePzJjmPjXNDA1ijuGxSUnMyy1KL9O0SuDIW PtjMVrCBreLJxSnMDYxrWbsYOTkkBEwk7nx4wAxhi0lcuLeerYuRi0NIYAejROu+21DOZ0aJ z+uXssB0rHjymBUisZJR4vbd50wgCTYBQ4nXfX+ZQBIiAi+YJWY2TQHrYBaQkdg3sQ2sSFjA UeLJmstgNouAqsTSnjY2EJtXwF3iy+F1QFM5gDYoSMyZZAMyR0LgO5vEtOvbmSDishKbDjBD mC4SHzYbQtwjLPHq+BZ2CFtKovnjB1aI1mOMEo+fL2aCcC4zSmw5vQyqyl7i2q3X7BC38Um8 +9oDtZdXoqNNCKLEQ+LkkxeMELajxPQPS8FBJCQQK7GhdwbLBEapBYwMqxjFUguKc9NTiw0L jPWKE3OLS/PS9ZLzczcxguNay3wH44ZzPocYBTgYlXh4I+S7IoRYE8uKK3MPMUpwMCuJ8OqK dUcI8aYkVlalFuXHF5XmpBYfYpTmYFES513caB0hJJCeWJKanZpakFoEk2Xi4JRqYOxYtPSI 0btD795/rBT+Fj453ykvumaqL4vQz4/Ft95dc5E+FWJ+ia3cgzWyT+/X2bQ9vofmrHdQ/XFF zvlDjbORk3vWm8KSk4aRhzeIegpHdqvVyWUuUY4r06ivLGzaHOG87vy583d4GU51315Zus7k mTfr0xalCb6WBx7tneX/li/wH8+VqUosxRmJhlrMRcWJAK0YkMznAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsWSnbNCVVdLpTvC4O5CYYv7076xWxxe9ILR 4tyrRywWS/etZrG4+ekbq8XlXXPYLDq/zGKz2DGllcXix6Qf7Ba35s1ks1j07RWzxauDbSwW P3fNY7H4e/ESmwOfx85Zd9k9epvfsXn0bVnF6PF5k5zHxrmhAaxRbjYZqYkpqUUKqXnJ+SmZ eem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMtY+GAzW8EGtoon F6cwNzCuZe1i5OSQEDCRWPHkMZQtJnHh3no2EFtIYDmjxPGNRiA2m4ChxOu+v0wgtojAJ2aJ /hMcIDazgIzEvoltYHFhAUeJJ2sug9ksAqoSS3vawObwCrhLfDm8Dmg+B9B8BYk5k2wmMHIt YGRYxSiWWlCcm55bXGBgqFecmFtcmpeul5yfu4kRGMbbDiuJ7WBsW+F1iFGAg1GJhzeBvTtC iDWxrLgy9xCjBAezkgivrhhQiDclsbIqtSg/vqg0J7X4EKMp0PaJzFKiyfnAGMsriTc0MbWw sDCxNDY2tjBREueNnf4sXEggPbEkNTs1tSC1CKaPiYNTqoGx09jzGMu0ebn/DZo0v/ZKGEw7 NvufAYv1y7NOhtrKB64mXfgf9e5b8Y0HmYu7n2x8rv3a1CLumDhv/rw1EtasCXL8An8y2eY+ 5m7veif7VP2u8rfs+QvMtKrm5y/es5i3K3p3hGLFtikzPrLIzjxxZpPtWu1ZatuY1xuICzRz GiTpTmq8Y/hfiaU4I9FQi7moOBEAbqW8k3kCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127104250epcas1p4cf918f7e98f557ae65136f027f7556f1 X-Msg-Generator: CA X-Sender-IP: 182.195.34.22 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170127104250epcas1p4cf918f7e98f557ae65136f027f7556f1 X-RootMTR: 20170127104250epcas1p4cf918f7e98f557ae65136f027f7556f1 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/input/keyboard/tegra-kbc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c index 0c07e10..1f213ba 100644 --- a/drivers/input/keyboard/tegra-kbc.c +++ b/drivers/input/keyboard/tegra-kbc.c @@ -617,6 +617,11 @@ static int tegra_kbc_probe(struct platform_device *pdev) const struct of_device_id *match; match = of_match_device(tegra_kbc_of_match, &pdev->dev); + + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } kbc = devm_kzalloc(&pdev->dev, sizeof(*kbc), GFP_KERNEL); if (!kbc) { -- 1.7.9.5