From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934421AbdA0LcI (ORCPT ); Fri, 27 Jan 2017 06:32:08 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:42269 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933758AbdA0LNL (ORCPT ); Fri, 27 Jan 2017 06:13:11 -0500 X-AuditID: b6c32a45-f79966d000001a3f-e7-588b2b28e849 From: Shailendra Verma To: Greg Kroah-Hartman , Cory Tusar , Vladimir Zapolskiy , Srinivas Kandagatla , Andrew Lunn , linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Misc: eeprom - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:42:31 +0530 Message-id: <1485515551-3191-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsWy7bCmha6GdneEwYXFmhbn7x5itrg/7Ru7 xYoNfUwWzYvXs1lc3jWHzWLHlFYWi1vzZrJZLPr2itmi7dgxVov/v5qZHbg8ds66y+5x59oe No/9c9ewe+zc8ZnJ49/CKSwebW/nM3r0bVnF6PF5k1wARxSXTUpqTmZZapG+XQJXxvGNd5kK +tkqlrduY2lg7GHtYuTkkBAwkXi0tosRwhaTuHBvPVsXIxeHkMAORombh5+yQzifGSUWHtzE BtMx5WQ7E0RiJaPE8R37wNrZBAwlXvf9BUuICPQzSyy494IFJCEsYCsx+/EKJhCbRUBV4lrb YnYQm1fAXWJO716gZg6gqQoScybZQCx4zyZx9IAuRFhWYtMBZoiwi8ShPyfYIWxhiVfHt0DZ UhKvdlxjBlkrIXCMUeLx88VMEM5lRoktp5dBVdlLXLv1GsxmFuCT6Dj8lx1iAa9ER5sQhOkh seGvIUS1o8TNc4vBISQkEAtUvY99AqPkAkaGVYxiqQXFuempxUYFhnrFibnFpXnpesn5uZsY wVGr5bqDccY5n0OMAhyMSjy8DLJdEUKsiWXFlbmHGCU4mJVEeHXFuiOEeFMSK6tSi/Lji0pz UosPMUpzsCiJ8/5bZx0hJJCeWJKanZpakFoEk2Xi4JRqYDyrUspRMHvlbrudHqsW7boTZ3rk XNDWT5sm3XXcMy1zw+wPiUmPAyf8qfsndfmHVnf2XWeW1phrlz4+Msp49eHFy5PRu+5tnH/4 YpScLYNZQn3lzE6x6lAxd/u3gS/CH0jKBq7J+XginjmRJ0v3KKfajxzxniQHqb7/61ZGfE6d VZNQtdzrcYcSS3FGoqEWc1FxIgBGB9AJ1gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsWSnbNCVVdduzvCoPE5q8X5u4eYLe5P+8Zu sWJDH5NF8+L1bBaXd81hs9gxpZXF4ta8mWwWi769YrZoO3aM1eL/r2ZmBy6PnbPusnvcubaH zWP/3DXsHjt3fGby+LdwCotH29v5jB59W1YxenzeJBfAEeVmk5GamJJapJCal5yfkpmXbqsU GuKma6GkkJeYm2qrFKHrGxKkpFCWmFMK5BkZoAEH5wD3YCV9uwS3jOMb7zIV9LNVLG/dxtLA 2MPaxcjJISFgIjHlZDsThC0mceHeerYuRi4OIYHljBIzGjezgSTYBAwlXvf9ZQJJiAhMZ5b4 eHczI0hCWMBWYvbjFWDdLAKqEtfaFrOD2LwC7hJzevcC1XAATVWQmDPJZgIj5wJGhlWMYqkF xbnpucUFBkZ6xYm5xaV56XrJ+bmbGIGhuu2wkvgOxlkrvA4xCnAwKvHwZvB1RwixJpYVV+Ye YpTgYFYS4dUVAwrxpiRWVqUW5ccXleakFh9iNAXaPpFZSjQ5HxhHeSXxhiamFhYWJpbGxsYW JkrivLHTn4ULCaQnlqRmp6YWpBbB9DFxcEo1MG7SX7AspP9QTWpm2xTu68wbb/lKbzj5XW7O gwWMth92bF7EnG7bM7+J5zt3Kt/2ScnPXRocZ9Stejfl3947hVsFLxZWGzutLbYxbmn8Hfv3 nxZbz3SDBPsLfrdyM4ts1tXc8zV+5tV/SzPP4/Xs7Y+3BzRcMNEJXJOwhOldgeKBBUfK1e69 W6bEUpyRaKjFXFScCAAj6j/OawIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127111239epcas2p41579f86bf18989151d77d7edd39dee9e X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170127111239epcas2p41579f86bf18989151d77d7edd39dee9e X-RootMTR: 20170127111239epcas2p41579f86bf18989151d77d7edd39dee9e References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/misc/eeprom/eeprom_93xx46.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c index 94cc035..6555975 100644 --- a/drivers/misc/eeprom/eeprom_93xx46.c +++ b/drivers/misc/eeprom/eeprom_93xx46.c @@ -381,6 +381,11 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi) enum of_gpio_flags of_flags; int ret; + if (!of_id) { + dev_err(&spi->dev, "Error: No device match found\n"); + return -ENODEV; + } + pd = devm_kzalloc(&spi->dev, sizeof(*pd), GFP_KERNEL); if (!pd) return -ENOMEM; -- 1.7.9.5