From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934093AbdA0LQa (ORCPT ); Fri, 27 Jan 2017 06:16:30 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:58107 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933401AbdA0LQ1 (ORCPT ); Fri, 27 Jan 2017 06:16:27 -0500 X-AuditID: b6c32a21-f79126d000001a27-7f-588b2c04f2db From: Shailendra Verma To: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Tty: serial - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:46:13 +0530 Message-id: <1485515773-3542-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWy7bCmgi6LTneEwdEzPBb3p31jt2hevJ7N YsqGD0wWl3fNYbM4s7iX3WLHlFYWi1vzZrJZLPr2itmBw2PnrLvsHvvnrmH36NuyitFj/Zar LB6fN8kFsEZx2aSk5mSWpRbp2yVwZWz/9ImxYDpbRcvdB0wNjN2sXYwcHBICJhLtf3O6GDmB TDGJC/fWs3UxcnEICSxllPjx7hQ7hPOZUWLi35+sEFUmEqtvXWOESKxklPiz4DgzSIJNwFDi dd9fJhBbRGA5k8S6Zg8QW1jARmLGjnawZhYBVYmOVwfBbF4Bd4m/V+ezQ1yhIDFnkg3ITAmB E2wSL17tYoSIy0psOsAMsddF4sTPp0wQtrDEq+Nb2CFsKYmTsx+wQ/QeY5R4/HwxE4RzmVFi y+llUFX2EtduvQazmQX4JOZ0H2SCWMAr0dEmBFHiIdF05BoLhO0o8e7mTDBbSCBW4uzsf4wT GCUXMDKsYhRLLSjOTU8tNikw1CtOzC0uzUvXS87P3cQIjkEtxR2M1xZ4H2IU4GBU4uH9sKQr Qog1say4MvcQowQHs5IIr65Yd4QQb0piZVVqUX58UWlOavEhRmkOFiVx3usN1hFCAumJJanZ qakFqUUwWSYOTqkGRkNLmcgHGY3XVhjFPDAUfaA6e+vrazrvuu8enCq0UVpC9Fx3sfOGYGEd 2QOMJfZ+XPeWph3vOtT5aMI8JvsZGYo8EV/iP3x0UvGy9BN/+oYtZ+3UM7lMM81Np72+47bP wpp1l8ZbZxH/ZZHhxa/Oz/bjOnWkQH3PwoCnfwp5NV033F0VtLcpSImlOCPRUIu5qDgRANGe fEm9AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsWSnbNCVZdZpzvC4PNLAYv7076xWzQvXs9m MWXDByaLy7vmsFmcWdzLbrFjSiuLxa15M9ksFn17xezA4bFz1l12j/1z17B79G1ZxeixfstV Fo/Pm+QCWKPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwj AzTg4BzgHqykb5fglrH90yfGgulsFS13HzA1MHazdjFyckgImEisvnWNEcIWk7hwbz0biC0k sJxR4u0fARCbTcBQ4nXfX6YuRi4OEYG1TBInjx5gBkkIC9hIzNjRDjaIRUBVouPVQTCbV8Bd 4u/V+exdjBxAQxUk5kyymcDIuYCRYRWjWGpBcW56bnGBgYlecWJucWleul5yfu4mRmDYbTus JLmDcdUKr0OMAhyMSjy8O/Z1RQixJpYVV+YeYpTgYFYS4dUV644Q4k1JrKxKLcqPLyrNSS0+ xGgKtH0is5Rocj4wJvJK4g1NTC0sLEwsjY2NLUyUxHljpz8LFxJITyxJzU5NLUgtgulj4uCU amB8xfrgXXxKweqQNUdlmfRrTvw8Wip6Nbt36ZmlC98blofsYG8vNYm9cOX8Y0m2yNyrWXOf +rZPDCybav10xYkj144FCje+mx91g6v7+Pakt1tOS0RZHOs+bGDXkiuxW75CUKp7q9ipVP1Z 1oeyo553PN22/0t38NNiE56a6KQ5Pw+mLN1X1XhXiaU4I9FQi7moOBEAR1/K4lECAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127111619epcas4p44c21059f85b7aa091016019c98d42939 X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 104P X-HopCount: 7 X-CMS-RootMailID: 20170127111619epcas4p44c21059f85b7aa091016019c98d42939 X-RootMTR: 20170127111619epcas4p44c21059f85b7aa091016019c98d42939 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/tty/serial/max310x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 8a3e926..a94d147 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1323,6 +1323,10 @@ static int max310x_spi_probe(struct spi_device *spi) if (spi->dev.of_node) { const struct of_device_id *of_id = of_match_device(max310x_dt_ids, &spi->dev); + if (!of_id) { + dev_err(&spi->dev, "Error: No device match found\n"); + return -ENODEV; + } devtype = (struct max310x_devtype *)of_id->data; } else { -- 1.7.9.5