From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934054AbdA0LSL (ORCPT ); Fri, 27 Jan 2017 06:18:11 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:37442 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933689AbdA0LSI (ORCPT ); Fri, 27 Jan 2017 06:18:08 -0500 X-AuditID: b6c32a24-f79ea6d000001a2b-7f-588b2c635e61 From: Shailendra Verma To: Matthias Brugger , John Crispin , Henry Chen , Daniel Kurtz , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Soc: mediatek - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:47:48 +0530 Message-id: <1485515868-3671-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsWy7bCmvG6yTneEwZm1ShZ/Jx1jt7g/7Ru7 xcnmG4wWjTPms1rc/T6LyWLT42usFpd3zWGzuNx8kdGiqcXYYseUVhaLW/Nmslks+vaK2YHH 4/evSYwesxsusnjsnHWX3WPzknqPlpP7WTy2LM7w6NuyitHj8ya5AI4oLpuU1JzMstQifbsE royPNzgLLrFVrGv8yt7AeIy1i5GDQ0LARKLnik8XIyeQKSZx4d56ti5GLg4hgaWMEre+f2IE SQgJfGaUOLiZFaLIROLPnWuMEEUrgYou7GIHSbAJGEq87vvLBGKLCBxkllh7VQvEFhawk5hw /TbYIBYBVYml27exgSzmFXCXWHwtDOIGBYk5k2xARkoIfGaT6PuwkhkiLiux6QAzxFoXia5F ILeB2MISr45vYYewpSROzn7ADtF7jFHi8fPFTBDOZUaJLaeXQVXZS1y79RrMZhbgk5jTfZAJ YgGvREebEESJh8S7lf+hyh0lOg9tBTtTSCBWYtmP/AmMkgsYGVYxiqUWFOempxabFJjoFSfm Fpfmpesl5+duYgTHrpbKDsYfC7wPMQpwMCrx8DqEdkUIsSaWFVfmHmKU4GBWEuHVFeuOEOJN SaysSi3Kjy8qzUktPsQozcGiJM57vcE6QkggPbEkNTs1tSC1CCbLxMEp1cBYddtGNl8+4G1h WGeWevaxh981u4U7Lpt+Xfb/Tb2MxFmri5GX+j9+u7jNrf7zf3/ztfbSugciz07Y6zX5Z2t0 r8OiJTZmXeut+Hdrucr8M5vG/1tyRuDDhXdD25bLpB1bclg+vcBr6T4+7QPB342z028GbqvN edD3KWPCIs1Tu6WOcixM196mxFKckWioxVxUnAgAM7CWuNkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsWSnbNCVTdZpzvCYOpKMYu/k46xW9yf9o3d 4mTzDUaLxhnzWS3ufp/FZLHp8TVWi8u75rBZXG6+yGjR1GJssWNKK4vFrXkz2SwWfXvF7MDj 8fvXJEaP2Q0XWTx2zrrL7rF5Sb1Hy8n9LB5bFmd49G1ZxejxeZNcAEeUm01GamJKapFCal5y fkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBnZIAGHJwD3IOV9O0S3DI+3uAsuMRW sa7xK3sD4zHWLkZODgkBE4k/d64xQthiEhfurWcDsYUEljNK9M4KBLHZBAwlXvf9Zepi5OIQ ETjNLNG5fQVYkbCAncSE67fBmlkEVCWWbt8GFOfg4BVwl1h8LQzElBBQkJgzyWYCI+cCRoZV jGKpBcW56bnFBQYmesWJucWleel6yfm5mxiBIbvtsJLkDsZVK7wOMQpwMCrx8O7Y1xUhxJpY VlyZe4hRgoNZSYRXV6w7Qog3JbGyKrUoP76oNCe1+BCjKdDyicxSosn5wHjKK4k3NDG1sLAw sTQ2NrYwURLnjZ3+LFxIID2xJDU7NbUgtQimj4mDU6qBcYJf/jGXVMEl3JHeLMHv433EWp/f fFZ6iZNLOLJHbVGRE9PbwNoVz0rqDX4xpiZNXF4jcM3iYdv97ZVuc0vsc303W/MafryTp8Ed L7qlfGv4gW7OuT5CmQUmpr1CR0/VufuEljW76iUuaXn9+V8F57lD/XK5s97nP94yJesin8TR 2VufXpmkxFKckWioxVxUnAgAj7sOeG8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127111755epcas4p4f4bf0401e49ddd4563b0365b838d3dde X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 104P X-HopCount: 7 X-CMS-RootMailID: 20170127111755epcas4p4f4bf0401e49ddd4563b0365b838d3dde X-RootMTR: 20170127111755epcas4p4f4bf0401e49ddd4563b0365b838d3dde References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/soc/mediatek/mtk-pmic-wrap.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index a5f1093..c48db98 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -1117,6 +1117,11 @@ static int pwrap_probe(struct platform_device *pdev) const struct of_device_id *of_slave_id = NULL; struct resource *res; + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + if (pdev->dev.of_node->child) of_slave_id = of_match_node(of_slave_match_tbl, pdev->dev.of_node->child); -- 1.7.9.5