From: Joe Perches <joe@perches.com>
To: Derek Robson <robsonde@gmail.com>,
w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org,
shraddha.6596@gmail.com, alan@linux.intel.com, shiva@exdev.nl,
amitoj1606@gmail.com, amsfield22@gmail.com, bhumirks@gmail.com,
waltfeasel@gmail.com
Cc: speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: speakup - syle fix permissions to octal
Date: Fri, 27 Jan 2017 22:14:31 -0800 [thread overview]
Message-ID: <1485584071.25660.4.camel@perches.com> (raw)
In-Reply-To: <20170128060509.21260-1-robsonde@gmail.com>
On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote:
> A style fix across whole driver.
> changed permissions to octal style, found using checkpatch
[]
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
> @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(SPEAKUP_VERSION);
>
> char *synth_name;
> -module_param_named(synth, synth_name, charp, S_IRUGO);
> -module_param_named(quiet, spk_quiet_boot, bool, S_IRUGO);
> +module_param_named(synth, synth_name, charp, 0444 );
> +module_param_named(quiet, spk_quiet_boot, bool, 0444 );
Please don't add spaces before the close parenthesis.
next prev parent reply other threads:[~2017-01-28 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 6:05 Derek Robson
2017-01-28 6:14 ` Joe Perches [this message]
2017-02-04 4:44 ` Guenter Roeck
2017-02-04 7:27 ` Joe Perches
2017-02-04 14:22 ` Guenter Roeck
2017-02-04 14:29 ` Julia Lawall
2017-02-04 15:17 ` Guenter Roeck
2017-02-04 15:25 ` Julia Lawall
2017-02-04 18:10 ` Julia Lawall
2017-02-04 18:32 ` Joe Perches
2017-02-04 19:24 ` Julia Lawall
2017-02-04 19:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485584071.25660.4.camel@perches.com \
--to=joe@perches.com \
--cc=alan@linux.intel.com \
--cc=amitoj1606@gmail.com \
--cc=amsfield22@gmail.com \
--cc=bhumirks@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=robsonde@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=shiva@exdev.nl \
--cc=shraddha.6596@gmail.com \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
--cc=waltfeasel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome