From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbdA3FAL (ORCPT ); Mon, 30 Jan 2017 00:00:11 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:45161 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbdA3FAE (ORCPT ); Mon, 30 Jan 2017 00:00:04 -0500 X-AuditID: b6c32a28-f79196d00000191c-6f-588ec844463d From: Shailendra Verma To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Stefan Agner , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Mtd: nand - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:29:17 +0530 Message-id: <1485752357-29817-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsWy7bCmvK7Lib4Ig8PH+S3uT/vGbnHgxUIW iyMX1jJb3Pt+ntli4srJzBaXd81hs9jdtIzd4uiee8wWO6a0slhM3vmG0eLWvJlsFou+vWK2 2Lyund2B12Px93vMHgt+bWXxeLLpIqPHzll32T02r9Dy2Lyk3uPmvEKPvi2rGD0+b5IL4Izi sklJzcksSy3St0vgyph7fR57wX/OijdXvzM1MK7m6GLk5JAQMJF4fmQ+I4QtJnHh3nq2LkYu DiGBpYwS5xfsY4ZwPjNKLOn+C5ThAOs4dcwJIr6SUeJtawczSDebgKHE676/TCAJEYH/zBK7 /lxkAUkIC1hJnO/aCraCRUBV4sSbT+wgNq+Ah0T7//msEEMVJOZMsgHplRBoZ5dov9QGFZeV 2HSAGcJ0kfi+oBTiUGGJV8e3sEPYUhInZz9gh2g9xijx+PliJgjnMqPEltPLoKrsJa7deg1m MwvwSczpPsgEMZRXoqNNCKLEQ6LpyGmoHx0l7i01ATGFBGIlnp+pncAouYCRYRWjWGpBcW56 arFJgYVecWJucWleul5yfu4mRnBMa2nsYPywwPsQowAHoxIP74r6vggh1sSy4srcQ4wSHMxK IrzlO4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW81WEcICaQnlqRmp6YWpBbBZJk4OKUaGHPb 2Ouc4tVs5uY/5thrGaVvKJYS5XwucG9+1fJJoaUvyiM85hZyaDFLeHuGuFdLKPjpM87301/x 9V+h4JzVHV+MZ5X+L/h9I3U2c9bHXaKifK6X7qgFfmhdFnArd0HgS4tzDIUGQZ/Ejth9U573 reZ57m95g7liai5MupFK/vyHfuct4JNRYinOSDTUYi4qTgQAIoTZXuUCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWSnbNCVdf5RF+EwZKv5hb3p31jtzjwYiGL xZELa5kt7n0/z2wxceVkZovLu+awWexuWsZucXTPPWaLHVNaWSwm73zDaHFr3kw2i0XfXjFb bF7Xzu7A67H4+z1mjwW/trJ4PNl0kdFj56y77B6bV2h5bF5S73FzXqFH35ZVjB6fN8kFcEa5 2WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ 3y7BLWPu9XnsBf85K95c/c7UwLiao4uRg0NCwETi1DGnLkZOIFNM4sK99WxdjFwcQgLLGSW+ 7zjLDpJgEzCUeN33lwkkISLQySLx4uMWsISwgJXE+a6tjCA2i4CqxIk3n8DivAIeEu3/57NC LFCQmDPJZgIj5wJGhlWMYqkFxbnpucUFBiZ6xYm5xaV56XrJ+bmbGIGhvO2wkuQOxlUrvA4x CnAwKvHwOuzqixBiTSwrrsw9xCjBwawkwlu+EyjEm5JYWZValB9fVJqTWnyI0RRo+0RmKdHk fGCc5ZXEG5qYWlhYmFgaGxtbmCiJ88ZOfxYuJJCeWJKanZpakFoE08fEwSnVwLhv6+lXPk7L p5Xvkwo822erF9R69kTErx0X7v6WulQR9pPl7qktUjdf5Kdyrq4r+H4vcu50xx6GEhXLXeWt ttGJHBXTZuaxfJmVHKLg8MVtwpxpyjouDKeuykwp3He7+s8N3TOGjO6clgueFIYfva0vVXjl rKbiQ9v2glD7FwZRoeutl509bqvEUpyRaKjFXFScCADfiJlKewIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130045947epcas4p48c244819af3cad2c5f1f8120192611d2 X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 104P X-HopCount: 7 X-CMS-RootMailID: 20170130045947epcas4p48c244819af3cad2c5f1f8120192611d2 X-RootMTR: 20170130045947epcas4p48c244819af3cad2c5f1f8120192611d2 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/mtd/nand/mxc_nand.c | 4 ++++ drivers/mtd/nand/vf610_nfc.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index d7f724b..ca1b8ad 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1596,6 +1596,10 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) if (!np) return 1; + if (!of_id) { + dev_err(host->dev, "Error: No device match found\n"); + return -ENODEV; + } host->devtype_data = of_id->data; return 0; diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 3ad514c..0e09c11 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -674,6 +674,10 @@ static int vf610_nfc_probe(struct platform_device *pdev) } of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev); + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } nfc->variant = (enum vf610_nfc_variant)of_id->data; for_each_available_child_of_node(nfc->dev->of_node, child) { -- 1.7.9.5