From: Brian Starkey <brian.starkey@arm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Sean Paul" <seanpaul@chromium.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Lionel Landwerlin" <lionel.g.landwerlin@intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: [PATCH v2] drm/color: Document CTM eqations
Date: Tue, 31 Jan 2017 10:48:34 +0000 [thread overview]
Message-ID: <1485859714-26619-1-git-send-email-brian.starkey@arm.com> (raw)
Explicitly state the expected CTM equations in the kerneldoc for the CTM
property, and the form of the matrix on struct drm_color_ctm.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
---
drivers/gpu/drm/drm_color_mgmt.c | 13 +++++++++++++
include/uapi/drm/drm_mode.h | 8 +++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
index 789b4c65cd69..7573ca4b6ea6 100644
--- a/drivers/gpu/drm/drm_color_mgmt.c
+++ b/drivers/gpu/drm/drm_color_mgmt.c
@@ -62,6 +62,19 @@
* unit/pass-thru matrix should be used. This is generally the driver
* boot-up state too.
*
+ * The output vector is related to the input vector as below:
+ *
+ * | ``out[0] = matrix[0] * in[0] + matrix[1] * in[1] + matrix[2] * in[2];``
+ * | ``out[1] = matrix[3] * in[0] + matrix[4] * in[1] + matrix[5] * in[2];``
+ * | ``out[2] = matrix[6] * in[0] + matrix[7] * in[1] + matrix[8] * in[2];``
+ *
+ * The component order in the input/output vectors is assumed to be
+ * { R, G, B }.
+ *
+ * The color-space of the input vector must not be confused with the
+ * color-space implied by a framebuffer pixel format, which may be the same
+ * or different.
+ *
* “GAMMA_LUT”:
* Blob property to set the gamma lookup table (LUT) mapping pixel data
* after the transformation matrix to data sent to the connector. The
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index ce7efe2e8a5e..3401637caf8e 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -525,7 +525,13 @@ struct drm_mode_crtc_lut {
};
struct drm_color_ctm {
- /* Conversion matrix in S31.32 format. */
+ /*
+ * Conversion matrix in S31.32 format, in row-major form:
+ *
+ * | matrix[0] matrix[1] matrix[2] |
+ * | matrix[3] matrix[4] matrix[5] |
+ * | matrix[6] matrix[7] matrix[8] |
+ */
__s64 matrix[9];
};
--
1.7.9.5
next reply other threads:[~2017-01-31 10:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 10:48 Brian Starkey [this message]
2017-01-31 11:30 ` Jani Nikula
2017-01-31 12:02 ` Brian Starkey
2017-01-31 12:37 ` Jani Nikula
2017-01-31 15:18 ` Ville Syrjälä
2017-01-31 15:39 ` Brian Starkey
2017-01-31 17:22 ` Ville Syrjälä
2017-01-31 17:46 ` Daniel Vetter
2017-02-15 11:39 ` Ville Syrjälä
2017-02-15 11:56 ` Daniel Stone
2017-02-17 13:54 ` Brian Starkey
2017-02-17 14:42 ` Lionel Landwerlin
2017-02-17 14:56 ` Ville Syrjälä
2017-02-17 15:05 ` Lionel Landwerlin
2017-02-17 15:16 ` Ville Syrjälä
2017-02-17 15:15 ` Daniel Stone
2017-02-26 19:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485859714-26619-1-git-send-email-brian.starkey@arm.com \
--to=brian.starkey@arm.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®