From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdAaTyj (ORCPT ); Tue, 31 Jan 2017 14:54:39 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36260 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdAaTy2 (ORCPT ); Tue, 31 Jan 2017 14:54:28 -0500 Message-ID: <1485892411.6360.139.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152 From: Eric Dumazet To: Guenter Roeck Cc: "David S . Miller" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hayes Wang Date: Tue, 31 Jan 2017 11:53:31 -0800 In-Reply-To: <1485889577-4389-1-git-send-email-linux@roeck-us.net> References: <1485889577-4389-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-31 at 11:06 -0800, Guenter Roeck wrote: > When unloading the r8152 driver using the 'unbind' sysfs attribute > in a system with KASAN enabled, the following error message is seen > on a regular basis. > > static int alloc_all_mem(struct r8152 *tp) > @@ -1423,10 +1420,6 @@ static int alloc_all_mem(struct r8152 *tp) > if (!tp->intr_urb) > goto err1; > > - tp->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL); > - if (!tp->intr_buff) > - goto err1; > - > tp->intr_interval = (int)ep_intr->desc.bInterval; > usb_fill_int_urb(tp->intr_urb, tp->udev, usb_rcvintpipe(tp->udev, 3), > tp->intr_buff, INTBUFSIZE, intr_callback, This might lead to intr_buff being backed by vzalloc() instead of kzalloc() (check alloc_netdev_mqs()) It looks like it could cause a bug.