From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751155AbdBAAyw (ORCPT ); Tue, 31 Jan 2017 19:54:52 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59350 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdBAAyu (ORCPT ); Tue, 31 Jan 2017 19:54:50 -0500 X-ME-Sender: X-Sasl-enc: GyI3BxcJFmJiy7lQZ1gb+selSxdp9IuQAKiB3XwJi0lB 1485910335 Message-ID: <1485910329.4137.34.camel@aj.id.au> Subject: Re: [PATCH v3] gpio: aspeed: Add banks Y, Z, AA, AB and AC From: Andrew Jeffery To: Linus Walleij Cc: Joel Stanley , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , OpenBMC Maillist Date: Wed, 01 Feb 2017 11:22:09 +1030 In-Reply-To: References: <20170127042442.28994-1-andrew@aj.id.au> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-la8e7fYaMZ3DauAZ2YlT" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-la8e7fYaMZ3DauAZ2YlT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-01-31 at 15:50 +0100, Linus Walleij wrote: > > On Fri, Jan 27, 2017 at 5:24 AM, Andrew Jeffery wrote= : >=20 > > This is less straight-forward than one would hope, as some banks only > > have 4 pins rather than 8, others are output only, yet more (W and > > X, already supported) are input-only, and in the case of the g4 SoC ban= k > > AC doesn't exist. > >=20 > > Add some structs to describe the varying properties of different banks > > and integrate mechanisms to deny requests for unsupported > > configurations. > >=20 > > > > Signed-off-by: Andrew Jeffery > > --- > >=20 > > Since v2: >=20 > Patch applied with some patch -p1 < fuzz > please check the result. Have you pushed the tree with the fuzzy patch applied? I can't find it. I fetched the gpio (and pinctrl) trees just now, but all I'm seeing is: $ git log --all --author "Andrew Jeffery" --committer "Linus Walleij" -= -grep "AA, AB" --oneline 1736f75d35e4 gpio: aspeed: Add banks Y, Z, AA, AB and AC 8ccb6dc6e999 pinctrl: aspeed: g4: Fix mux configuration for GPIOs AA[4-= 7], AB[0-7] and=20 $ git show --stat --pretty=3Dfuller 1736f75d35e4 commit 1736f75d35e47409ad776273133d0f558a4c8253 Author: Andrew Jeffery < andrew@aj.id.au > AuthorDate: Tue Jan 24 16:46:46 2017 +1030 Commit: Linus Walleij < linus.walleij@linaro.org > CommitDate: Thu Jan 26 14:45:43 2017 +0100 v3 wasn't sent until Friday the 27th, and the diff of 1736f75d35e4 still drags in which v3 removes. Regardless, I'll try to recreate it myself and inspect the fuzz damage. --=-la8e7fYaMZ3DauAZ2YlT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYkTE6AAoJEJ0dnzgO5LT55KkP/RDY7rZPVAlqCwzjeYjna7br uaTnAhwXx8Bgf2WGe8fDeXW6r+cBOtKjflp5lQcyPg7Ji2U+YvMR1+3DbwRelWFW cnEV6DijgLF7dv7hpWPL8DgDYcR4xi7T84jZBJ+c9IAeNrPOGLcLNE121e/l0c0E Dm4hdgC96oSDFzzio/K2fuvnSs0t+Ge+KdMpBFUJ8GAYATX+Ls6J/2S/oh/vEYly cqPAHM085eXpjMdwQVmv8LHSNiZXis5jz79CPpFZiQWH1wUS9gbYKbt0jF2pLjYM 79tJ2juKK6pLfVtSEr4hvoRSpdID3gfq+hmS964h33/AM0+qVrzS5j3Gu2j+Wm4l UqrGwUao8EgwvD8NJ4LyoLDRjE0sGft4+IcpU5IjeBoKKIE06AIYlg6pWYX7WeN0 LBttMGQyiJTgDNXFWXtxj+d6olmqRi4CcgDkxC8BChTgxl6eFIENL/i1jkRHxp8c bXx6tsERO87a6eZV4txxYb7ozx19dsD40fyjQa8w/dDiOjpQ4DQm79Don6zZFHVf yms0MMP/EEOXCOstYkJZm8E72NRiYce0rRn+E9PKgOsJYfxuEhKEEZtTDUrknNtp 0aKpABiRAy5zqB99m+NrmXRftUAiHH91/rSISAfLBvwPzc/61PBQ/W8ZYKwvYQQE /UQmr1yTtrO2ZZr2VtAD =ZtDw -----END PGP SIGNATURE----- --=-la8e7fYaMZ3DauAZ2YlT--