mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@aj.id.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] gpio: aspeed: Add banks Y, Z, AA, AB and AC
Date: Wed, 01 Feb 2017 11:50:24 +1030	[thread overview]
Message-ID: <1485912024.4137.36.camel@aj.id.au> (raw)
In-Reply-To: <1485910329.4137.34.camel@aj.id.au>

[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]

On Wed, 2017-02-01 at 11:22 +1030, Andrew Jeffery wrote:
> On Tue, 2017-01-31 at 15:50 +0100, Linus Walleij wrote:
> > > > > > On Fri, Jan 27, 2017 at 5:24 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> > > This is less straight-forward than one would hope, as some banks only
> > > have 4 pins rather than 8, others are output only, yet more (W and
> > > X, already supported) are input-only, and in the case of the g4 SoC bank
> > > AC doesn't exist.
> > > 
> > > Add some structs to describe the varying properties of different banks
> > > and integrate mechanisms to deny requests for unsupported
> > > configurations.
> > > 
> > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > 
> > > ---
> > > 
> > > Since v2:
> > 
> > Patch applied with some patch -p1 < fuzz
> > please check the result.
> 

*snip*

> Regardless, I'll try to recreate it myself and inspect the fuzz damage.

Ah, I think I see what's happened. I didn't send "gpio: aspeed: Make
bank names strings" again because you claimed you had applied v1 in the
v2 thread[1]. This patch doesn't fuzz when "gpio: aspeed: Make bank
names strings" has been applied, so is it possible that you tried
applying it to a tree missing "gpio: aspeed: Make bank names strings"?

    $ git reset --hard gpio/for-next
    HEAD is now at f334eae9c4e9 Merge branch 'devel' into for-next
    $ git am "/home/andrew/patches/[PATCH_v2_1_2]_gpio:_aspeed:_Make_bank_names_strings.mbox"
    Applying: gpio: aspeed: Make bank names strings
    $ git am "/home/andrew/patches/[PATCH_v3]_gpio:_aspeed:_Add_banks_Y,_Z,_AA,_AB_and_AC.mbox"
    Applying: gpio: aspeed: Add banks Y, Z, AA, AB and AC
    $

    Sorry for the confusion. What should I be doing when sending an updated
    series where some of the patches have been applied? Send the whole
    series regardless?

    Andrew

    [1]     https://lkml.org/lkml/2017/1/26/334

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2017-02-01  1:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27  4:24 Andrew Jeffery
2017-01-27  5:53 ` Joel Stanley
2017-01-31 14:50 ` Linus Walleij
2017-02-01  0:52   ` Andrew Jeffery
2017-02-01  1:20     ` Andrew Jeffery [this message]
2017-02-01 14:58       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485912024.4137.36.camel@aj.id.au \
    --to=andrew@aj.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®