From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbdBAI2c (ORCPT ); Wed, 1 Feb 2017 03:28:32 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:63818 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdBAI2b (ORCPT ); Wed, 1 Feb 2017 03:28:31 -0500 From: Kishon Vijay Abraham I To: CC: , , Stephen Boyd Subject: [PATCH] phy: qcom-usb-hs: Add depends on EXTCON Date: Wed, 1 Feb 2017 13:57:44 +0530 Message-ID: <1485937664-25545-1-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") while using extcon API's in qcom-usb-hs failed to add 'depends on EXTCON' resulting in the following compile errors if EXTCON is not enabled. drivers/built-in.o: In function `qcom_usb_hs_phy_power_off': phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier' drivers/built-in.o: In function `qcom_usb_hs_phy_probe': phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle' drivers/built-in.o: In function `qcom_usb_hs_phy_power_on': phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state' phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier' Fix it here. Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy") Cc: Stephen Boyd Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index bb5cf6f..c11aba6 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -440,6 +440,7 @@ config PHY_QCOM_UFS config PHY_QCOM_USB_HS tristate "Qualcomm USB HS PHY module" + depends on EXTCON depends on USB_ULPI_BUS select GENERIC_PHY help -- 1.7.9.5