From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbdBAJ0c (ORCPT ); Wed, 1 Feb 2017 04:26:32 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55591 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbdBAJ0a (ORCPT ); Wed, 1 Feb 2017 04:26:30 -0500 Message-ID: <1485941168.21479.38.camel@pengutronix.de> Subject: Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition. From: Lucas Stach To: Liviu Dudau Cc: David Airlie , Russell King , Christian Gmeiner , etnaviv@lists.freedesktop.org, DRI devel , LKML , Dave Jiang Date: Wed, 01 Feb 2017 10:26:08 +0100 In-Reply-To: <20170131185849.8297-2-liviu@dudau.co.uk> References: <20170131185849.8297-1-liviu@dudau.co.uk> <20170131185849.8297-2-liviu@dudau.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liviu, Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau: > Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite > to take only vmf") updated the etnaviv_gem_fault() function signature > without updating the header file with the declaration. > There is already a patch from Arnd on the list that fixes this issue. https://lkml.org/lkml/2017/1/25/718 Regards, Lucas > Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf") > Cc: Dave Jiang > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > index c255eda40526..e41f38667c1c 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, > struct drm_file *file); > > int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma); > -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf); > +int etnaviv_gem_fault(struct vm_fault *vmf); > int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset); > struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj); > void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);