From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdBAWL3 (ORCPT ); Wed, 1 Feb 2017 17:11:29 -0500 Received: from smtprelay0112.hostedemail.com ([216.40.44.112]:50243 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751018AbdBAWL1 (ORCPT ); Wed, 1 Feb 2017 17:11:27 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3867:3870:4321:5007:6119:6630:7903:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12438:12555:12731:12737:12740:12895:13071:13439:13894:14180:14181:14659:14721:21060:21080:21433:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: dirt45_c3d09e9f655d X-Filterd-Recvd-Size: 3193 Message-ID: <1485987082.22276.5.camel@perches.com> Subject: Re: [PATCH] staging: vt6656: Avoid multiple line dereference From: Joe Perches To: Craig Kewley , Forest Bond , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 01 Feb 2017 14:11:22 -0800 In-Reply-To: <20170201214337.48058-1-craigkewley@gmail.com> References: <20170201214337.48058-1-craigkewley@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-01 at 21:43 +0000, Craig Kewley wrote: > This patch fixes the checkpatch.pl warning: > WARNING: Avoid multiple line dereference Hi Craig. Please try to make the code more sensible in preference to just fixing checkpatch warnings. > diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c [] > @@ -692,8 +692,8 @@ static u16 vnt_generate_tx_parameter(struct vnt_usb_send_context *tx_context, > tx_context->pkt_type == PK_TYPE_11GA) { > if (need_rts) { > if (need_mic) > - *mic_hdr = &tx_buffer-> > - tx_head.tx_rts.tx.mic.hdr; > + *mic_hdr = > + &tx_buffer->tx_head.tx_rts.tx.mic.hdr; > > return vnt_rxtx_rts(tx_context, &tx_buffer->tx_head, > need_mic); This block would be more legible using a temporary for &tx_buffer->tx_head like: ---  drivers/staging/vt6656/rxtx.c | 15 +++++++--------  1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index aa59e7f14ab3..89ca5c20cd1c 100644 --- a/drivers/staging/vt6656/rxtx.c +++ b/drivers/staging/vt6656/rxtx.c @@ -687,28 +687,27 @@ static u16 vnt_generate_tx_parameter(struct vnt_usb_send_context *tx_context,   struct vnt_mic_hdr **mic_hdr, u32 need_mic,   bool need_rts)  { + union vnt_tx_head *tx_head = &tx_buffer->tx_head;     if (tx_context->pkt_type == PK_TYPE_11GB ||       tx_context->pkt_type == PK_TYPE_11GA) {   if (need_rts) {   if (need_mic) - *mic_hdr = &tx_buffer-> - tx_head.tx_rts.tx.mic.hdr; + *mic_hdr = &tx_head->tx_rts.tx.mic.hdr;   - return vnt_rxtx_rts(tx_context, &tx_buffer->tx_head, -     need_mic); + return vnt_rxtx_rts(tx_context, tx_head, need_mic);   }     if (need_mic) - *mic_hdr = &tx_buffer->tx_head.tx_cts.tx.mic.hdr; + *mic_hdr = &tx_head->tx_cts.tx.mic.hdr;   - return vnt_rxtx_cts(tx_context, &tx_buffer->tx_head, need_mic); + return vnt_rxtx_cts(tx_context, tx_head, need_mic);   }     if (need_mic) - *mic_hdr = &tx_buffer->tx_head.tx_ab.tx.mic.hdr; + *mic_hdr = &tx_head->tx_ab.tx.mic.hdr;   - return vnt_rxtx_ab(tx_context, &tx_buffer->tx_head, need_rts, need_mic); + return vnt_rxtx_ab(tx_context, tx_head, need_rts, need_mic);  }    static void vnt_fill_txkey(struct vnt_usb_send_context *tx_context,