From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751643AbdBCR5H (ORCPT ); Fri, 3 Feb 2017 12:57:07 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33206 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbdBCR41 (ORCPT ); Fri, 3 Feb 2017 12:56:27 -0500 Message-ID: <1486144585.21871.92.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable From: Eric Dumazet To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 03 Feb 2017 09:56:25 -0800 In-Reply-To: <1486143755-192532-6-git-send-email-shannon.nelson@oracle.com> References: <1486143755-192532-1-git-send-email-shannon.nelson@oracle.com> <1486143755-192532-6-git-send-email-shannon.nelson@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > In order to allow the underlying LDC and outstanding memory operations > to potentially catch up with the driver's Tx requests, add a memory > barrier before checking again for available tx descriptors. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/sun/sunvnet_common.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c > index 5d0d386..98e758e 100644 > --- a/drivers/net/ethernet/sun/sunvnet_common.c > +++ b/drivers/net/ethernet/sun/sunvnet_common.c > @@ -1467,6 +1467,7 @@ ldc_start_done: > dr->prod = (dr->prod + 1) & (VNET_TX_RING_SIZE - 1); > if (unlikely(vnet_tx_dring_avail(dr) < 1)) { > netif_tx_stop_queue(txq); > + dma_wmb(); This does not look right. I believe you need smp_rmb() here. > if (vnet_tx_dring_avail(dr) > VNET_TX_WAKEUP_THRESH(dr)) > netif_tx_wake_queue(txq); > }