From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdBCR7d (ORCPT ); Fri, 3 Feb 2017 12:59:33 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34632 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdBCR7b (ORCPT ); Fri, 3 Feb 2017 12:59:31 -0500 Message-ID: <1486144770.21871.94.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations From: Eric Dumazet To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 03 Feb 2017 09:59:30 -0800 In-Reply-To: <1486143755-192532-10-git-send-email-shannon.nelson@oracle.com> References: <1486143755-192532-1-git-send-email-shannon.nelson@oracle.com> <1486143755-192532-10-git-send-email-shannon.nelson@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > The ldmvsw driver is specifically for supporting the ldom virtual > networking by running in the primary ldom and using the LDC to connect > the remaining ldoms to the outside world via a bridge. With TSO and GSO > supported while connected the bridge, things tend to misbehave as seen in > our case by delayed packets, enough to begin triggering retransmits and > affecting overall throughput. By turning off advertised support for TSO > and GSO we restore stable traffic flow through the bridge. > > Orabug: 23293104 > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/sun/ldmvsw.c | 5 ++--- > drivers/net/ethernet/sun/sunvnet_common.c | 3 ++- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c > index 552c0a9..bd2cfbc 100644 > --- a/drivers/net/ethernet/sun/ldmvsw.c > +++ b/drivers/net/ethernet/sun/ldmvsw.c > @@ -299,8 +299,7 @@ static struct net_device *vsw_alloc_netdev(u8 hwaddr[], > dev->ethtool_ops = &vsw_ethtool_ops; > dev->watchdog_timeo = VSW_TX_TIMEOUT; > > - dev->hw_features = NETIF_F_TSO | NETIF_F_GSO | NETIF_F_GSO_SOFTWARE | > - NETIF_F_HW_CSUM | NETIF_F_SG; > + dev->hw_features = NETIF_F_HW_CSUM; You also removed NETIF_F_SG