From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbdBFJ4k (ORCPT ); Mon, 6 Feb 2017 04:56:40 -0500 Received: from mail.kernel.org ([198.145.29.136]:45536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbdBFJ4j (ORCPT ); Mon, 6 Feb 2017 04:56:39 -0500 From: Masami Hiramatsu To: Ingo Molnar Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Peter Zijlstra , Ananth N Mavinakayanahalli , Thomas Gleixner , "H . Peter Anvin" Subject: [PATCH tip/master 2/2] kprobes: x86: Use hlist_for_each_entry() for first loop Date: Mon, 6 Feb 2017 18:55:43 +0900 Message-Id: <148637493309.19245.12546866092052500584.stgit@devbox> X-Mailer: git-send-email 2.9.3 In-Reply-To: <148637479268.19245.5046175731172022619.stgit@devbox> References: <148637479268.19245.5046175731172022619.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use hlist_for_each_entry() for first loop on kretprobe trampoline_handler because it doesn't change the hlist. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index eb35093..520b8df 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -745,7 +745,7 @@ __visible __used void *trampoline_handler(struct pt_regs *regs) * will be the real return address, and all the rest will * point to kretprobe_trampoline. */ - hlist_for_each_entry_safe(ri, tmp, head, hlist) { + hlist_for_each_entry(ri, head, hlist) { if (ri->task != current) /* another task is sharing our hash bucket */ continue;