Re: [PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Wednesday, April 24, 2013 04:40:38 PM Viresh Kumar wrote:
> On Wed, Apr 24, 2013 at 4:34 PM, Chen Gang <gang.chen@asianux.com> wrote:
> >
> > For arm S5pv210 with allmodconfig, ARM_S5PV210_CPUFREQ need
> > CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue.
> >
> > The related operation:
> > + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_vmlinux1 -T /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kernel/head.o init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/built-in.o arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm/built-in.o arch/arm/common/built-in.o arch/arm/net/built-in.o arch/arm/crypto/built-in.o arch/arm/mach-s5pv210/built-in.o arch/arm/plat-samsung/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o block/built-in.o arch/arm/lib/lib.a lib/lib.a arch/arm/lib/built-in.o lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o net/built-in.o --end-group
> >
> > The related errors:
> > drivers/built-in.o: In function `s5pv210_target':
> > drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to `cpufreq_frequency_table_target'
> > drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to `cpufreq_frequency_table_target'
> > drivers/built-in.o: In function `s5pv210_verify_speed':
> > drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to `cpufreq_frequency_table_verify'
> > drivers/built-in.o: In function `s5pv210_cpu_init':
> > drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to `cpufreq_frequency_table_get_attr'
> > drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to `cpufreq_frequency_table_cpuinfo'
> > make: *** [vmlinux] Error 1
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> > ---
> >  drivers/cpufreq/Kconfig.arm |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index bce2195..bbcd719 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ
> >  config ARM_S5PV210_CPUFREQ
> >         bool "Samsung S5PV210 and S5PC110"
> >         depends on CPU_S5PV210
> > +       select CPU_FREQ_TABLE
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.