From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbdBIOTJ (ORCPT ); Thu, 9 Feb 2017 09:19:09 -0500 Received: from smtp.citrix.com ([66.165.176.89]:45437 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbdBIOSH (ORCPT ); Thu, 9 Feb 2017 09:18:07 -0500 X-IronPort-AV: E=Sophos;i="5.35,349,1484006400"; d="scan'208";a="405748659" From: Paul Durrant To: , CC: Paul Durrant , Boris Ostrovsky , Juergen Gross Subject: [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs Date: Thu, 9 Feb 2017 14:17:44 +0000 Message-ID: <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> References: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code goes so far as to set the default return code to -ENOSYS but then overrides this to -EINVAL in the switch() statement's default case. This patch removes this pointless and incorrect override. Signed-off-by: Paul Durrant --- Cc: Boris Ostrovsky Cc: Juergen Gross --- drivers/xen/privcmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 6e3306f..b4e5e27 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file, break; default: - ret = -EINVAL; break; } -- 2.1.4